Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release procedure changes & nominating @sam-github and @jasnell as releasers #2416

Closed
rvagg opened this issue Aug 18, 2015 · 12 comments
Closed

Comments

@rvagg
Copy link
Member

rvagg commented Aug 18, 2015

I'm proposing that we fully unify the release process for 0.10, 0.12, io.js, 4.x+ and LTS. Initially I thought that having separate groups for different concerns was the way to go but now I think that's over-optimising and we should just reduce friction and let people gravitate towards the release lines that they are more concerned with—if we have a big enough group of releasers then we should be covered. I also think our current procedures for getting sign-off via GitHub is suffice to stop any unwanted changes getting out into LTS & Maintainence where we need to take much more care.

Current status:

  • 0.10 and 0.12 have been handled previously by @misterdjules and now @sam-github and @jasnell have been given access & instructions on how to do this. @cjihrig also expressed interest in helping out there. @misterdjules would rather not be responsible for releases.
  • io.js releases have been handled by @chrisdickinson, @Fishrock123, @cjihrig and myself and our GPG keys are currently the only ones listed on the nodejs/node README which is obviously inaccurate for "Node.js".
  • Node.js v4 hasn't had any releases yet so we don't have this fully sorted out. LTS hasn't started yet so that's only been briefly discussed and nothing more.

I propose that we:

  1. Put @sam-github, @jasnell, @chrisdickinson, @Fishrock123, @cjihrig and myself on the @nodejs/release team
  2. Add GPG key fingerprints for @sam-github and @jasnell on the README here, for historical accuracy we should also list fingerprints for Isaac, TJ and Julien somewhere on there too
  3. Add the ssh keys of the entire @nodejs/release team to the new incarnation of nodejs.org so they can perform the full release procedure for any release line (exactly how this will work is still under consideration and will be some kind of mash-up of the joyent/node procedure with the io.js procedure)
  4. Add the GPG key fingerprints of the @nodejs/release team to the Dockerfiles /cc @nodejs/docker

Relevant docs on how it's currently handled:

Tagging this as tsc-agenda because it'll need formal sign-off. @sam-github and @jasnell may choose to decline, and all of this is up for discussion by collaborators as well of course.

@rvagg
Copy link
Member Author

rvagg commented Aug 18, 2015

should have mentioned @nodejs/tsc for this one, sorry

@jasnell
Copy link
Member

jasnell commented Aug 18, 2015

I'm happy to accept assuming their are no objections. GPG key can be found here: https://keybase.io/jasnell

@orangemocha
Copy link
Contributor

Sounds like a good plan. +1

@Fishrock123
Copy link
Member

👍

@sam-github
Copy link
Contributor

I'm happy to help out with releases, gpg keys at https://keybase.io/octetcloud

@chrisdickinson
Copy link
Contributor

I may need to add a new gpg key (likely my keybase one), I erased my old one when switching laptops.

@rvagg
Copy link
Member Author

rvagg commented Aug 20, 2015

@chrisdickinson can you confirm https://keybase.io/chrisdickinson / 9554F04D7259F04124DE6B476D5A82AC7E37093B?

I'll do this in a single PR.

@rvagg
Copy link
Member Author

rvagg commented Aug 20, 2015

err, 9554F04D7259F04124DE6B476D5A82AC7E37093B is what's already in the README. Is there another one you've used? We should list all of the keys that have previously been used.

@rvagg
Copy link
Member Author

rvagg commented Aug 20, 2015

this was voted on by the TSC today and both additions got a +1 and there were no objections to the plan to mush together a release team for all branches

@Fishrock123
Copy link
Member

Can this be closed then? Or is it also for this week's?

@rvagg
Copy link
Member Author

rvagg commented Aug 26, 2015

waiting for feedback and signoff on #2455, I'll remove the label though

@rvagg rvagg removed the tsc-agenda label Aug 26, 2015
rvagg added a commit to rvagg/io.js that referenced this issue Aug 26, 2015
Fixes: nodejs#2416
PR-URL: nodejs#2455
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg added a commit that referenced this issue Aug 26, 2015
Fixes: #2416
PR-URL: #2455
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@cjihrig
Copy link
Contributor

cjihrig commented Aug 26, 2015

Closing since #2455 landed.

@cjihrig cjihrig closed this as completed Aug 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants