Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upRefactor RealEnvStore methods to use uv_os_getenv/setenv/unsetenv #27211
Comments
joyeecheung
added
good first issue
os
process
C++
labels
Apr 13, 2019
This comment has been minimized.
This comment has been minimized.
|
Prior work: #14641 It seems easier to refactor |
This comment has been minimized.
This comment has been minimized.
devasci
commented
Apr 15, 2019
|
Hi, It seems to be a good item for me as a first timer. I will work one this and will share the updates soon. |
devasci
added a commit
to devasci/node
that referenced
this issue
Apr 19, 2019
devasci
added a commit
to devasci/node
that referenced
this issue
Apr 19, 2019
This comment has been minimized.
This comment has been minimized.
devasci
commented
Apr 19, 2019
|
Modified as Joyee Cheung suggested and tested by following contributors guide. Created pull request: #27310 |
devasci
added a commit
to devasci/node
that referenced
this issue
Apr 19, 2019
devasci
added a commit
to devasci/node
that referenced
this issue
Apr 19, 2019
devasci
added a commit
to devasci/node
that referenced
this issue
Apr 19, 2019
devasci
added a commit
to devasci/node
that referenced
this issue
Apr 19, 2019
devasci
added a commit
to devasci/node
that referenced
this issue
Apr 19, 2019
devasci
added a commit
to devasci/node
that referenced
this issue
Apr 19, 2019
devasci
added a commit
to devasci/node
that referenced
this issue
Apr 20, 2019
devasci
added a commit
to devasci/node
that referenced
this issue
Apr 20, 2019
devasci
added a commit
to devasci/node
that referenced
this issue
Apr 20, 2019
devasci
added a commit
to devasci/node
that referenced
this issue
Apr 20, 2019
devasci
added a commit
to devasci/node
that referenced
this issue
Apr 20, 2019
devasci
added a commit
to devasci/node
that referenced
this issue
Apr 20, 2019
devasci
added a commit
to devasci/node
that referenced
this issue
Apr 20, 2019
devasci
added a commit
to devasci/node
that referenced
this issue
Apr 20, 2019
devasci
added a commit
to devasci/node
that referenced
this issue
Apr 22, 2019
devasci
added a commit
to devasci/node
that referenced
this issue
Apr 24, 2019
devasci
added a commit
to devasci/node
that referenced
this issue
Apr 24, 2019
devasci
added a commit
to devasci/node
that referenced
this issue
Apr 24, 2019
devasci
added a commit
to devasci/node
that referenced
this issue
Apr 24, 2019
devasci
added a commit
to devasci/node
that referenced
this issue
Apr 24, 2019
devasci
added a commit
to devasci/node
that referenced
this issue
Apr 24, 2019
devasci
added a commit
to devasci/node
that referenced
this issue
Apr 24, 2019
devasci
added a commit
to devasci/node
that referenced
this issue
Apr 24, 2019
devasci
added a commit
to devasci/node
that referenced
this issue
Apr 24, 2019
devasci
added a commit
to devasci/node
that referenced
this issue
Apr 24, 2019
devasci
added a commit
to devasci/node
that referenced
this issue
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
joyeecheung commentedApr 13, 2019
•
edited
From a glance I think the uv_os_* methods are adequate to replace our conditional switches in the RealEnvStore methods.
I think this is a good first issue if you are familiar with C++ and has some idea on how to use libuv methods, but you may need to read into the libuv implementation to make sure the refactor does not change the functionality.
Pointers:
node/src/node_env_var.cc
Line 71 in dfd7e99
node/src/node_env_var.cc
Line 107 in dfd7e99
node/src/node_env_var.cc
Line 123 in dfd7e99
node/src/node_env_var.cc
Line 146 in dfd7e99
docs:
http://docs.libuv.org/en/v1.x/misc.html?highlight=uv_os_getenv#c.uv_os_getenv
http://docs.libuv.org/en/v1.x/misc.html?highlight=uv_os_getenv#c.uv_os_setenv
http://docs.libuv.org/en/v1.x/misc.html?highlight=uv_os_getenv#c.uv_os_unsetenv