test/parallel/test-dgram-connect.js fails locally

[joyeecheung]

/Users/joyee/projects/node/test/parallel/test-dgram-connect.js:40
    assert.ok(err.code === 'ENOTFOUND' || err.code === 'EAI_AGAIN');
                  ^

TypeError: Cannot read property 'code' of undefined
    at Socket.<anonymous> (/Users/joyee/projects/node/test/parallel/test-dgram-connect.js:40:19)
    at Socket.<anonymous> (/Users/joyee/projects/node/test/common/index.js:373:15)
    at Object.onceWrapper (events.js:284:20)
    at Socket.emit (events.js:196:13)
    at dgram.js:418:31
    at processTicksAndRejections (internal/process/task_queues.js:81:9)

Does not reproduce if I turn my Wifi off (it's probably hijacking DNS requests to invalid domains), so I guess either this should be moved to internet instead, or we should mock the lookup.

[Trott]

Does it start working if you replace addresses.INVALID_HOST with invalid.test?

[Trott]

Does it start working if you replace addresses.INVALID_HOST with invalid.test?

Oops, never mind. It's already using a IETF-reserved invalid name.

[joyeecheung]

@Trott yeah, the issue is that the ISP may not be doing what it's supposed to do and it could e.g. hijack the invalid DNS request so that when you visit it in the browser it redirects you to a page full of their ads :/

[joyeecheung]

I guess the easiest solution is to move this test to test/internet because it sends out actual DNS requests.

[santigimeno]

I guess the easiest solution is to move this test to test/internet because it sends out actual DNS requests.

I think this is fine, but I would just move that specific test not the whole file.