Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debugger.setInstrumentationBreakpoint is broken #31138

Open
ulitink opened this issue Dec 30, 2019 · 2 comments
Open

Debugger.setInstrumentationBreakpoint is broken #31138

ulitink opened this issue Dec 30, 2019 · 2 comments
Labels
inspector Issues and PRs related to the V8 inspector protocol

Comments

@ulitink
Copy link
Contributor

ulitink commented Dec 30, 2019

  • Version: v14.0.0-pre, master branch
  • Platform: Linux
  • Subsystem: inspector

Newly added Debugger.setInstrumentationBreakpoint inspector API doesn't work for me. Changes were introduced for request #24687. The same API works fine in Chrome.

I've created a test #31137. Breakpoints for scripts with sourcemaps only don't work either. If I use the protocol incorrectly, please let me know which additional methods should be called.
@addaleax addaleax added the inspector Issues and PRs related to the V8 inspector protocol label Dec 30, 2019
@addaleax
Copy link
Member

@nodejs/v8-inspector

@ulitink ulitink mentioned this issue Jan 5, 2020
Merged
3 tasks
@Soarex16
Copy link

Any updates for this issue?

aduh95 pushed a commit that referenced this issue May 12, 2024
@ulitink
test: add Debugger.setInstrumentationBreakpoint known issue
291c121 
PR-URL: #31137
Refs: #31138
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue May 13, 2024
@ulitink @targos
test: add Debugger.setInstrumentationBreakpoint known issue
e016e95 
PR-URL: #31137
Refs: #31138
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
lukins-cz pushed a commit to lukins-cz/OS-Aplet-node that referenced this issue Jun 1, 2024
@ulitink @lukins-cz
test: add Debugger.setInstrumentationBreakpoint known issue
516a1a0 
PR-URL: nodejs#31137
Refs: nodejs#31138
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@addaleax @ulitink @Soarex16 and others