Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools/gflags are useless now that eslint is used ? #3217

Closed
kapouer opened this issue Oct 6, 2015 · 1 comment
Closed

tools/gflags are useless now that eslint is used ? #3217

kapouer opened this issue Oct 6, 2015 · 1 comment
Labels
tools Issues and PRs related to the tools directory.

Comments

@kapouer
Copy link
Contributor

kapouer commented Oct 6, 2015

Naïve grep shows it's useless.
As far as i understand, closure linter needed gflags, and then was replaced by eslint.
@mscdex mscdex added the tools Issues and PRs related to the tools directory. label Oct 6, 2015
@bnoordhuis bnoordhuis mentioned this issue Oct 6, 2015
Merged
@bnoordhuis
Copy link
Member

#3220

bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Oct 6, 2015
@bnoordhuis
tools: remove unused gflags module
87d2615 
Its only dependant was closure-linter but that was removed in commit
f9dd34d ("tools: replace closure-linter with eslint").  Remove it.

Fixes: nodejs#3217
PR-URL: nodejs#3220
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
bnoordhuis added a commit that referenced this issue Oct 8, 2015
@bnoordhuis @jasnell
tools: remove unused gflags module
18a8b2e 
Its only dependant was closure-linter but that was removed in commit
f9dd34d ("tools: replace closure-linter with eslint").  Remove it.

Fixes: #3217
PR-URL: #3220
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mscdex @kapouer @bnoordhuis