tools: remove unused gflags module #3220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM if CI is happy. |
Its only dependant was closure-linter but that was removed in commit f9dd34d ("tools: replace closure-linter with eslint"). Remove it. Fixes: nodejs#3217 PR-URL: nodejs#3220 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
bnoordhuis
force-pushed
the
remove-gflags
branch
from
35e1cea
to
87d2615
Compare
|
Sigh, test-stringbytes-external.js on ARM again... landed in 87d2615 and thanks for the review, Trevor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its only dependant was closure-linter but that was removed in commit
f9dd34d ("tools: replace closure-linter with eslint"). Remove it.
Fixes: #3217
CI: https://ci.nodejs.org/job/node-test-pull-request/433/