Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Either ensure that specific GPG keys used to sign releases are mentioned in README(.md) or indicate that the key could be a sub-key of a key listed (which itself isn't listed), with a sentence or 2 to minimize the time spent on sub-key aspect, if applicable #32559

Closed
haqer1 opened this issue Mar 30, 2020 · 3 comments

Comments

@haqer1
Copy link
Contributor

haqer1 commented Mar 30, 2020

  • Version: 12.6.1
  • Platform: Linux

What steps will reproduce the bug?

gpg --verify SHASUMS256.txt.sig

What is the expected behavior?

Key used should be mentioned on README(.md).

What do you see instead?

gpg --verify SHASUMS256.txt.sig
gpg: assuming signed data in 'SHASUMS256.txt'
gpg: Signature made ...
gpg: using RSA key 0EFFE1BCEFD9C84E3D098152933B01F40B5CA946

I.e., key is not mentioned on README.

@haqer1
Copy link
Contributor Author

haqer1 commented Mar 30, 2020

I see that the 2 keys are related. Yet, it's confusing to see a key that's not documented on the README: this requires the user to spend extra time on verifying what's going on.

P.S. All the other release developers have 1 key each on README, so i'm not sure whether listing both related keys for 1 release developers is an option (although it would be sufficient for verification purposes).
P.P.S. Perhaps some scripting could also be considered to make sure that the key used to sign a release is listed in README.md...

My 2 cents.

@ahwayakchih
Copy link

ahwayakchih commented Mar 30, 2020

@haqer1 problem with GPG/PGP keys is being discussed for a long time now:

  1. Release PGP key strategy and policy #709
  2. New strategy for managing, sharing and documenting release keys needed build#1913

It looks like there will be a separate repository for release keys (although it still would need to be kept up-to-date with whatever key is used to sign releases), as proposed by @canterberry:

nodejs/admin#456

It just takes forever to finalize :(

haqer1 added a commit to haqer1/node that referenced this issue Mar 30, 2020
… is mentioned in README(.md) (alternative approach)

Update README.md.

Fixes: nodejs#32559
@haqer1 haqer1 changed the title Ensure that GPG key used to sign the latest LTS release (12.6.1) is mentioned in README(.md) Either ensure that specific GPG keys used to sign releases are mentioned in README(.md) or indicate that the key could be a sub-key of a key listed (which itself isn't listed) Apr 1, 2020
haqer1 added a commit to haqer1/node that referenced this issue Apr 1, 2020
…sed to sign a release could be a sub-key of a key listed in README(.md) (which itself isn't listed in it)

Update README.md.

Fixes: nodejs#32559
@haqer1
Copy link
Contributor Author

haqer1 commented Apr 1, 2020

I've installed a lot of software & until this nodejs installation i've never seen a sub-key of a key listed on the software provider's site (which itself isn't listed) having been used to sign a release: IMHO, this is confusing & leads to waste of time.

Therefore,

haqer1 added a commit to haqer1/node that referenced this issue Apr 1, 2020
…d to import a key used to sign a release & check whether it is a sub-key of a primary key listed in README(.md) (which itself isn't listed in it)...

Addition README.md update

Fixes: nodejs#32559
haqer1 added a commit to haqer1/node that referenced this issue Apr 4, 2020
…d to import a key used to sign a release & check whether it is a sub-key of a primary key listed in README(.md) (which itself isn't listed in it)...

Additional README.md update

Fixes: nodejs#32559
haqer1 added a commit to haqer1/node that referenced this issue Apr 4, 2020
…d to import the full set of trusted release keys (rather than an individual key)

Additional README.md update

Fixes: nodejs#32559
@haqer1 haqer1 changed the title Either ensure that specific GPG keys used to sign releases are mentioned in README(.md) or indicate that the key could be a sub-key of a key listed (which itself isn't listed) Either ensure that specific GPG keys used to sign releases are mentioned in README(.md) or indicate that the key could be a sub-key of a key listed (which itself isn't listed), with a sentence or 2 to minimize the time spent on sub-key aspect, if applicable Apr 4, 2020
MylesBorins pushed a commit that referenced this issue Apr 17, 2020
PR-URL: #32591
Fixes: #32559
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
targos pushed a commit to targos/node that referenced this issue Apr 25, 2020
PR-URL: nodejs#32591
Fixes: nodejs#32559
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
BridgeAR pushed a commit that referenced this issue Apr 28, 2020
PR-URL: #32591
Fixes: #32559
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
targos pushed a commit that referenced this issue Apr 28, 2020
PR-URL: #32591
Fixes: #32559
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
haqer1 added a commit to haqer1/node that referenced this issue Oct 28, 2020
…d to import the full set of trusted release keys (rather than an individual key) (reconciled with another suggestion from code review)

The OP finds his original suggestion more descriptive & more user-friendly, but prefers to move on since that suggestion is stalled in favor of much shorter verbiage

Co-Authored-By: Myles Borins <mylesborins@google.com>

Fixes: nodejs#32559
haqer1 added a commit to haqer1/node that referenced this issue Oct 28, 2020
…d to import the full set of trusted release keys (rather than an individual key) (reconciled with another suggestion from code review)

The OP finds his original suggestion more descriptive & more user-friendly, but prefers to move on since that suggestion is stalled in favor of much shorter verbiage. This version also splits the line at 80 characters to comply with lint-md.

Co-Authored-By: Myles Borins <mylesborins@google.com>

Fixes: nodejs#32559
aduh95 pushed a commit that referenced this issue Nov 9, 2020
PR-URL: #32655
Fixes: #32559
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
danielleadams pushed a commit that referenced this issue Nov 9, 2020
PR-URL: #32655
Fixes: #32559
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
BethGriggs pushed a commit that referenced this issue Dec 9, 2020
PR-URL: #32655
Fixes: #32559
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
BethGriggs pushed a commit that referenced this issue Dec 10, 2020
PR-URL: #32655
Fixes: #32559
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
BethGriggs pushed a commit that referenced this issue Dec 15, 2020
PR-URL: #32655
Fixes: #32559
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment