Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 'writable' and 'readable' to 'new stream.Duplex(options)' docs. #34382

Closed
preyunk opened this issue Jul 15, 2020 · 0 comments
Closed

add 'writable' and 'readable' to 'new stream.Duplex(options)' docs. #34382

preyunk opened this issue Jul 15, 2020 · 0 comments

Comments

@preyunk
Copy link
Contributor

preyunk commented Jul 15, 2020

maybe that's the reason we don't get the option to set writable and readable property as options while creating a new Duplex.

That option actually does exist and should be used. It's just not documented, which we should fix.

Originally posted by @ronag in #34374 (comment)
@preyunk preyunk changed the title add writable and readable to new stream.Duplex(options) docs. add 'writable' and 'readable' to 'new stream.Duplex(options)' docs. Jul 15, 2020
@preyunk preyunk mentioned this issue Jul 15, 2020
Closed
3 tasks
preyunk added a commit to preyunk/node that referenced this issue Jul 15, 2020
@preyunk
doc: add writable and readable options to Duplex docs
d2e695d 
Fixes: nodejs#34382
MylesBorins pushed a commit that referenced this issue Aug 17, 2020
@preyunk @MylesBorins
doc: add writable and readable options to Duplex docs
4377690 
Fixes: #34382

PR-URL: #34383
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BethGriggs pushed a commit that referenced this issue Aug 20, 2020
@preyunk @BethGriggs
doc: add writable and readable options to Duplex docs
b93ba07 
Fixes: #34382

PR-URL: #34383
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
addaleax pushed a commit that referenced this issue Sep 22, 2020
@preyunk @addaleax
doc: add writable and readable options to Duplex docs
2260037 
Fixes: #34382

PR-URL: #34383
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
addaleax pushed a commit that referenced this issue Sep 22, 2020
@preyunk @addaleax
doc: add writable and readable options to Duplex docs
0ba9052 
Fixes: #34382

PR-URL: #34383
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: add writable and readable options to Duplex docs preyunk/node
1 participant
@preyunk