Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Dark Mode for NodeJS docs #35793

Closed
AjayPoshak opened this issue Oct 25, 2020 · 12 comments · Fixed by #36313
Closed

Enable Dark Mode for NodeJS docs #35793

AjayPoshak opened this issue Oct 25, 2020 · 12 comments · Fixed by #36313
Labels
doc Issues and PRs related to the documentations. feature request Issues that request new features to be added to Node.js. help wanted Issues that need assistance from volunteers or PRs that need help to proceed.

Comments

@AjayPoshak
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Please enable dark mode for node docs like the nodejs.dev website.
@ChALkeR ChALkeR added doc Issues and PRs related to the documentations. feature request Issues that request new features to be added to Node.js. labels Oct 25, 2020
@AjayPoshak
Copy link
Contributor Author

I would like to work on it, if that's possible.

@DerekNonGeneric
Copy link
Contributor

@AjayPoshak, that is possible.

@dougmellon
Copy link

dougmellon commented Oct 26, 2020 •
edited

@AjayPoshak If you would like help, let me know and I will lend a hand.

Also, I suggest a good first issue tag for this issue.

@DerekNonGeneric DerekNonGeneric added the help wanted Issues that need assistance from volunteers or PRs that need help to proceed. label Oct 26, 2020
@dougmellon
Copy link

@AjayPoshak if you are not going to take this, I'll jump on it. Just let me know.

@DerekNonGeneric
Copy link
Contributor

@dougmellon, if you two would be interested in collaborating, that would be cool. @AjayPoshak hasn't expressed interest yet, so it's still up for grabs. May the best solution land. :)

@dougmellon
Copy link

Sounds good!

@AjayPoshak
Copy link
Contributor Author

@DerekNonGeneric @dougmellon I will be working on it this weekend.

@dougmellon
Copy link

@DerekNonGeneric @dougmellon I will be working on it this weekend.

Awesome. Do you mind if I help out?

@AjayPoshak
Copy link
Contributor Author

@dougmellon not at all. Let's work on it together.

@DerekNonGeneric
Copy link
Contributor

Just wanted to mention to the person who makes the PR with the commit: you can add the “Co-authored-by” trailer to the end of the commit message with the other person's name and preferred email to preserve attribution.

Refs: https://github.blog/2018-01-29-commit-together-with-co-authors/#how-it-works

@AjayPoshak
Copy link
Contributor Author

@dougmellon Please dm me on twitter, I could not find your contact info on profile.

jabyrd3 added a commit to jabyrd3/node that referenced this issue Nov 28, 2020
@jabyrd3
doc: add dark mode styles
04b1cb1 
Pulled colors from nodejs.dev

Refs: nodejs#35793
@jabyrd3 jabyrd3 mentioned this issue Nov 28, 2020
Closed
2 tasks
@jabyrd3
Copy link

jabyrd3 commented Nov 28, 2020

Looks like: https://www.dropbox.com/s/78kbivu5u8ds0tb/api_docs_darkmode.png?dl=0

@AjayPoshak AjayPoshak mentioned this issue Nov 29, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. feature request Issues that request new features to be added to Node.js. help wanted Issues that need assistance from volunteers or PRs that need help to proceed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add dark mode AjayPoshak/node
5 participants
@ChALkeR @jabyrd3 @AjayPoshak @DerekNonGeneric @dougmellon