Socket.readyState is initially open

[morkai]

• Version: v14.16.1
• Platform: Microsoft Windows NT 10.0.19042.0 x64
• Subsystem: net

What steps will reproduce the bug?

const {Socket} = require('net');
const socket = new Socket();
socket.on('connect', () => console.log('readyState in connect=', socket.readyState));
socket.on('close', () => console.log('readyState in close=', socket.readyState));
socket.on('error', (err) => console.log('readyState in error=', socket.readyState, err.message));
console.log('process.version=', process.version);
console.log('readyState before connect=', socket.readyState);
console.log('connecting...');
socket.connect(502, '192.168.1.1');
console.log('readyState after connect=', socket.readyState);

How often does it reproduce? Is there a required condition?

Always. No.

What is the expected behavior?

net.Socket.readyState should be initially closed like in the v12:

process.version= v12.22.1
readyState before connect= closed
connecting...
readyState after connect= opening
readyState in error= closed connect ECONNREFUSED 192.168.1.1:502
readyState in close= closed

What do you see instead?

net.Socket.readyState is open after initialization, before any call to connect():

process.version= v14.16.1
readyState before connect= open
connecting...
readyState after connect= opening
readyState in error= closed connect ECONNREFUSED 192.168.1.1:502
readyState in close= closed

Additional information

This change made the Socket start as readable & writable: eeccd52

In v12 one could check if the socket is open by socket.readyState === 'open'
In v14 another condition must be added !socket.pending && socket.readyState === 'open'

[EladKeyshawn]

Can confirm on master as well

[Ayase-252]

Per docs

This property represents the state of the connection as a string.
If the stream is connecting socket.readyState is opening.
If the stream is readable and writable, it is open.
If the stream is readable and not writable, it is readOnly.
If the stream is not readable and writable, it is writeOnly.

#32272 mades Socket starting as readable and writable then socket.readyState is working as intended? 🤔

[EladKeyshawn]

@Ayase-252 If that's the raw definition of 'open' socket means then yes, but I don't think it's very intuitive IMO.