Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows-build(doc): can't generate html file #38391

Closed
ahmadrasyidsalim opened this issue Apr 24, 2021 · 0 comments · Fixed by #38398
Closed

windows-build(doc): can't generate html file #38391

ahmadrasyidsalim opened this issue Apr 24, 2021 · 0 comments · Fixed by #38398
Labels
tools Issues and PRs related to the tools directory.

Comments

@ahmadrasyidsalim
Copy link

  • v17.0.0-pre:
  • Microsoft Windows NT 19042.928 x64:
  • Python 3.9.4:
  • VS2019 (16.9.31205.134):

What steps will reproduce the bug?

Trying to build doc

How often does it reproduce? Is there a required condition?

Every time

What is the expected behavior?

HTML file generated inside the doc\api directory

What do you see instead?

HTML file did not exist and I got this error message:

TypeError: versions.filter is not a function
    at altDocs (D:\Rasyid\Sources\Git\node\tools\doc\html.js:484:25)
    at Object.toHTML (D:\Rasyid\Sources\Git\node\tools\doc\html.js:108:40)
    at main (D:\Rasyid\Sources\Git\node\tools\doc\generate.js:97:29)
@Ayase-252 Ayase-252 added the build Issues and PRs related to build files or the CI. label Apr 25, 2021
aduh95 added a commit to aduh95/node that referenced this issue Apr 25, 2021
@aduh95
tools: fix doc generation when version info is not available
e82a98c 
Fixes: nodejs#38391
@aduh95 aduh95 mentioned this issue Apr 25, 2021
Merged
@Ayase-252 Ayase-252 added tools Issues and PRs related to the tools directory. and removed build Issues and PRs related to build files or the CI. labels Apr 25, 2021
@aduh95 aduh95 closed this as completed in 3d070d0 Apr 28, 2021
targos pushed a commit that referenced this issue Apr 29, 2021
@aduh95 @targos
tools: fix doc generation when version info is not available
dce8d29 
Fixes: #38391

PR-URL: #38398
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this issue May 30, 2021
@aduh95 @targos
tools: fix doc generation when version info is not available
20a610d 
Fixes: #38391

PR-URL: #38398
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this issue Jun 5, 2021
@aduh95 @targos
tools: fix doc generation when version info is not available
3baa658 
Fixes: #38391

PR-URL: #38398
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this issue Jun 5, 2021
@aduh95 @targos
tools: fix doc generation when version info is not available
11af09c 
Fixes: #38391

PR-URL: #38398
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this issue Jun 11, 2021
@aduh95 @targos
tools: fix doc generation when version info is not available
aec4b29 
Fixes: #38391

PR-URL: #38398
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tools: fix doc generation when version info is not available aduh95/node
2 participants
@Ayase-252 @ahmadrasyidsalim