Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the externally loaded builtins build #39090

Closed
mmomtchev opened this issue Jun 19, 2021 · 0 comments · Fixed by #39091
Closed

Fix the externally loaded builtins build #39090

mmomtchev opened this issue Jun 19, 2021 · 0 comments · Fixed by #39091

Comments

@mmomtchev
Copy link
Contributor

  • Version: 17 current
  • Platform: Linux
  • Subsystem: build

What steps will reproduce the bug?

./configure --node-builtin-modules-path $(pwd)
make -j4

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior?

Builds

What do you see instead?

../src/node_native_module.cc: In member function ‘v8::MaybeLocal<v8::String> node::native_module::NativeModuleLoader::LoadBuiltinModuleSource(v8::Isolate*, const char*)’:
../src/node_native_module.cc:211:29: error: ‘SPrintF’ was not declared in this scope
  211 |     const std::string buf = SPrintF("Cannot read local builtin. %s: %s \"%s\"",
      |                             ^~~~~~~
make[1]: *** [libnode.target.mk:384: /home/mmom/src/node/out/Release/obj.target/libnode/src/node_native_module.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:110: node] Error 2
mmomtchev added a commit to mmomtchev/node that referenced this issue Jun 19, 2021
@mmomtchev
Fix building with external builtins nodejs#39090
74b12e6
@aduh95 aduh95 mentioned this issue Jun 20, 2021
Merged
@aduh95 aduh95 closed this as completed in 19b80cc Jun 26, 2021
targos pushed a commit that referenced this issue Jul 11, 2021
@targos
build: fix building with external builtins
65b56b3 
PR-URL: #39091
Fixes: #39090
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RaisinTen pushed a commit to RaisinTen/node that referenced this issue Jul 18, 2021
@mmomtchev @RaisinTen
build: fix building with external builtins
e91b66f 
PR-URL: nodejs#39091
Fixes: nodejs#39090
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit to RaisinTen/node that referenced this issue Jul 19, 2021
@mmomtchev @richardlau
build: fix building with external builtins
86ab15d 
PR-URL: nodejs#39091
Fixes: nodejs#39090
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this issue Jul 19, 2021
@richardlau
build: fix building with external builtins
5f7c331 
PR-URL: #39091
Backport-PR-URL: #39419
Fixes: #39090
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this issue Jul 20, 2021
@richardlau
build: fix building with external builtins
1ab4f81 
PR-URL: #39091
Backport-PR-URL: #39419
Fixes: #39090
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
foxxyz pushed a commit to foxxyz/node that referenced this issue Oct 18, 2021
@mmomtchev @foxxyz
build: fix building with external builtins
72c0c71 
PR-URL: nodejs#39091
Backport-PR-URL: nodejs#39419
Fixes: nodejs#39090
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix building with external builtins #39090 mmomtchev/node
1 participant
@mmomtchev