Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: symlink docs contain erroneous sample code #40413

Closed
1 task
JacksonKearl opened this issue Oct 11, 2021 · 1 comment 路 Fixed by #40414
Closed
1 task

doc: symlink docs contain erroneous sample code #40413

JacksonKearl opened this issue Oct 11, 2021 · 1 comment 路 Fixed by #40414
Labels
doc Issues and PRs related to the documentations.

Comments

@JacksonKearl
Copy link

馃摋 API Reference Docs Problem

  • Version: 14, 16, possibly others
  • Platform: docs
  • Subsystem: fs

Location

Section of the site where the content exists

Affected URL(s):

Description

The example code should be:

import { symlink } from 'fs';

symlink('./mew', './mewtwo', callback);

rather than

import { symlink } from 'fs';

symlink('./mew', './example/mewtwo', callback);

image


  • I would like to work on this issue and
    submit a pull request.
@JacksonKearl JacksonKearl added the doc Issues and PRs related to the documentations. label Oct 11, 2021
juanarbol added a commit to juanarbol/node that referenced this issue Oct 11, 2021
@juanarbol
Copy link
Member

Nice catch! Thanks for the report

juanarbol added a commit to juanarbol/node that referenced this issue Oct 12, 2021
@aduh95 aduh95 closed this as completed in ced518c Oct 22, 2021
targos pushed a commit that referenced this issue Oct 23, 2021
Fixes: #40413

PR-URL: #40414
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
jodevsa pushed a commit to jodevsa/node that referenced this issue Oct 24, 2021
Fixes: nodejs#40413

PR-URL: nodejs#40414
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
BethGriggs pushed a commit that referenced this issue Nov 24, 2021
Fixes: #40413

PR-URL: #40414
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants