Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: internal repl's autocomplete is disruptive without inspector #40635

Closed
mscdex opened this issue Oct 27, 2021 · 0 comments · Fixed by #40661
Closed

repl: internal repl's autocomplete is disruptive without inspector #40635

mscdex opened this issue Oct 27, 2021 · 0 comments · Fixed by #40661
Labels
repl Issues and PRs related to the REPL subsystem.

Comments

@mscdex
Copy link
Contributor

mscdex commented Oct 27, 2021 •
edited

Version

v16.13.0 (and possibly others)

Platform

Linux foo 5.4.0-58-generic 64~18.04.1-Ubuntu SMP Wed Dec 9 17:11:11 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Subsystem

repl

What steps will reproduce the bug?

Compile node with --without-inspector, then start up the internal repl:

$ node
Welcome to Node.js v16.13.0.
Type ".help" for more information.
> const r = 10;
undefined

Now type r and press enter in the repl to have the repl display the value of r. You will find it instead forces the autocompletion of r to re and thus gives (the expected):

Uncaught ReferenceError: re is not defined

Pressing space after r and then enter in the repl causes the autocomplete to no longer complete and correctly shows the value of r.

How often does it reproduce? Is there a required condition?

Every time.

What is the expected behavior?

For the repl to not be disruptive when node is compiled with --without-inspector.

What do you see instead?

No response

Additional information

No response
@mscdex mscdex added the repl Issues and PRs related to the REPL subsystem. label Oct 27, 2021
Linkgoron added a commit to Linkgoron/node that referenced this issue Oct 29, 2021
@Linkgoron
repl: fix disruptive autocomplete without inspector
02158fb 
Fix an issue where the autocomplete wrongly autocompletes
a value from a correct value to an undefined value when node
is built without an inspector by disabling the preview view

fixes: nodejs#40635
@Linkgoron Linkgoron mentioned this issue Oct 29, 2021
Merged
Linkgoron added a commit to Linkgoron/node that referenced this issue Oct 30, 2021
@Linkgoron
repl: fix disruptive autocomplete without inspector
daacae8 
Fix an issue where the autocomplete wrongly autocompletes
a value from a correct value to an undefined value when node
is built without an inspector by disabling the preview view

fixes: nodejs#40635
Linkgoron added a commit to Linkgoron/node that referenced this issue Nov 1, 2021
@Linkgoron
repl: fix disruptive autocomplete without inspector
5d99dd2 
Fix an issue where the autocomplete wrongly autocompletes
a value from a correct value to an undefined value when node
is built without an inspector by disabling the preview view

fixes: nodejs#40635
Linkgoron added a commit to Linkgoron/node that referenced this issue Nov 2, 2021
@Linkgoron
repl: fix disruptive autocomplete without inspector
8d24eef 
Fix an issue where the autocomplete wrongly autocompletes
a value from a correct value to an undefined value when node
is built without an inspector by disabling the preview view

fixes: nodejs#40635
Linkgoron added a commit to Linkgoron/node that referenced this issue Nov 30, 2021
@Linkgoron
repl: fix disruptive autocomplete without inspector
82e0766 
Fix an issue where the autocomplete wrongly autocompletes
a value from a correct value to an undefined value when node
is built without an inspector by disabling the preview view

fixes: nodejs#40635
Linkgoron added a commit to Linkgoron/node that referenced this issue Nov 30, 2021
@Linkgoron
repl: fix disruptive autocomplete without inspector
612d73d 
Fix an issue where the autocomplete wrongly autocompletes
a value from a correct value to an undefined value when node
is built without an inspector by disabling the preview view

fixes: nodejs#40635
Linkgoron added a commit to Linkgoron/node that referenced this issue Jan 31, 2022
@Linkgoron
repl: fix disruptive autocomplete without inspector
5a724c6 
Fix an issue where the autocomplete wrongly autocompletes
a value from a correct value to an undefined value when node
is built without an inspector by disabling the preview view

fixes: nodejs#40635
aduh95 pushed a commit that referenced this issue May 12, 2024
@Linkgoron
repl: fix disruptive autocomplete without inspector
1223294 
Fix an issue where the autocomplete wrongly autocompletes
a value from a correct value to an undefined value when `node`
is built without an inspector by disabling the preview view.

fixes: #40635
PR-URL: #40661
Fixes: #40635
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue May 12, 2024
@Linkgoron @targos
repl: fix disruptive autocomplete without inspector
04de576 
Fix an issue where the autocomplete wrongly autocompletes
a value from a correct value to an undefined value when `node`
is built without an inspector by disabling the preview view.

fixes: #40635
PR-URL: #40661
Fixes: #40635
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
lukins-cz pushed a commit to lukins-cz/OS-Aplet-node that referenced this issue Jun 1, 2024
@Linkgoron @lukins-cz
repl: fix disruptive autocomplete without inspector
259cd71 
Fix an issue where the autocomplete wrongly autocompletes
a value from a correct value to an undefined value when `node`
is built without an inspector by disabling the preview view.

fixes: nodejs#40635
PR-URL: nodejs#40661
Fixes: nodejs#40635
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
marco-ippolito pushed a commit that referenced this issue Jun 17, 2024
@Linkgoron @marco-ippolito
repl: fix disruptive autocomplete without inspector
2bf8452 
Fix an issue where the autocomplete wrongly autocompletes
a value from a correct value to an undefined value when `node`
is built without an inspector by disabling the preview view.

fixes: #40635
PR-URL: #40661
Fixes: #40635
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
marco-ippolito pushed a commit that referenced this issue Jun 17, 2024
@Linkgoron @marco-ippolito
repl: fix disruptive autocomplete without inspector
7a812dd 
Fix an issue where the autocomplete wrongly autocompletes
a value from a correct value to an undefined value when `node`
is built without an inspector by disabling the preview view.

fixes: #40635
PR-URL: #40661
Fixes: #40635
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
marco-ippolito pushed a commit that referenced this issue Jun 17, 2024
@Linkgoron @marco-ippolito
repl: fix disruptive autocomplete without inspector
eceac78 
Fix an issue where the autocomplete wrongly autocompletes
a value from a correct value to an undefined value when `node`
is built without an inspector by disabling the preview view.

fixes: #40635
PR-URL: #40661
Fixes: #40635
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
sophoniie pushed a commit to sophoniie/node that referenced this issue Jun 20, 2024
@Linkgoron @sophoniie
repl: fix disruptive autocomplete without inspector
294a06a 
Fix an issue where the autocomplete wrongly autocompletes
a value from a correct value to an undefined value when `node`
is built without an inspector by disabling the preview view.

fixes: nodejs#40635
PR-URL: nodejs#40661
Fixes: nodejs#40635
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
bmeck pushed a commit to bmeck/node that referenced this issue Jun 22, 2024
@Linkgoron @bmeck
repl: fix disruptive autocomplete without inspector
c632b7b 
Fix an issue where the autocomplete wrongly autocompletes
a value from a correct value to an undefined value when `node`
is built without an inspector by disabling the preview view.

fixes: nodejs#40635
PR-URL: nodejs#40661
Fixes: nodejs#40635
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

repl: fix disruptive autocomplete without inspector Linkgoron/node
1 participant
@mscdex