Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate WHATWG Streams from Experimental? #40950

Closed
jasnell opened this issue Nov 24, 2021 · 6 comments · Fixed by #42225
Closed

Graduate WHATWG Streams from Experimental? #40950

jasnell opened this issue Nov 24, 2021 · 6 comments · Fixed by #42225
Labels
discuss Issues opened for discussions and feedbacks. web streams

Comments

@jasnell
Copy link
Member

jasnell commented Nov 24, 2021 •
edited

What else do we need to make sure gets done before graduating the WHATWG streams implementation from experimental?

/cc @nodejs/streams
@ronag
Copy link
Member

ronag commented Nov 24, 2021

#39758

@Mesteery Mesteery added the discuss Issues opened for discussions and feedbacks. label Nov 24, 2021
@mcollina
Copy link
Member

I would add #39316 as well.

@benjamingr
Copy link
Member

I don't think they've seen enough usage and adoption and I'd like us to be able to change them before we do.

I don't think there is rush to graduate them yet (is there?), I suspect once the community uses them more we'll uncover issues that might require breaking changes (in errors or API guarantees) and I believe that graduating them doesn't get us much and costs us the ability to make changes without long deprecation cycles.

@ronag
Copy link
Member

ronag commented Nov 25, 2021

I suspect once the community uses them more we'll uncover issues that might require breaking changes

How do we make this happen? i.e. more people uses them.

@benjamingr
Copy link
Member

@ronag I think we just wait and also ship other experimental APIs that use them?

We can also reach out to the community and explicitly ask for feedback

@mcollina
Copy link
Member

I think we could just drop the console warning on them and keep them as experimental in the docs (the same is true for Blob, File, etc..).

@jasnell jasnell mentioned this issue Nov 25, 2021
Merged
nodejs-github-bot pushed a commit that referenced this issue Dec 1, 2021
@jasnell
stream: remove whatwg streams experimental warning
94de738 
The API is still experimental, but the warning isn't necessary any
longer

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #40971
Refs: #40950
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
danielleadams pushed a commit that referenced this issue Dec 13, 2021
@jasnell @danielleadams
stream: remove whatwg streams experimental warning
6a35b17 
The API is still experimental, but the warning isn't necessary any
longer

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #40971
Refs: #40950
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
danielleadams pushed a commit that referenced this issue Dec 14, 2021
@jasnell @danielleadams
stream: remove whatwg streams experimental warning
0e21c64 
The API is still experimental, but the warning isn't necessary any
longer

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #40971
Refs: #40950
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
danielleadams pushed a commit that referenced this issue Jan 31, 2022
@jasnell @danielleadams
stream: remove whatwg streams experimental warning
ca8f6e7 
The API is still experimental, but the warning isn't necessary any
longer

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #40971
Refs: #40950
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this issue Jan 31, 2022
@jasnell @Linkgoron
stream: remove whatwg streams experimental warning
15c0abf 
The API is still experimental, but the warning isn't necessary any
longer

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#40971
Refs: nodejs#40950
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
danielleadams pushed a commit that referenced this issue Feb 1, 2022
@jasnell @danielleadams
stream: remove whatwg streams experimental warning
2251bba 
The API is still experimental, but the warning isn't necessary any
longer

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #40971
Refs: #40950
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
@aduh95 aduh95 mentioned this issue Mar 6, 2022
Merged
nodejs-github-bot pushed a commit that referenced this issue Apr 4, 2022
@aduh95
stream: expose web streams globals, remove runtime experimental warning
560cbc5 
PR-URL: #42225
Fixes: #40950
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
xtx1130 pushed a commit to xtx1130/node that referenced this issue Apr 25, 2022
@aduh95 @xtx1130
stream: expose web streams globals, remove runtime experimental warning
a393264 
PR-URL: nodejs#42225
Fixes: nodejs#40950
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discuss Issues opened for discussions and feedbacks. web streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stream: expose web streams globals, remove runtime experimental warning aduh95/node
5 participants
@mcollina @jasnell @benjamingr @ronag @Mesteery