-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebStreams "respondWithNewView" incorrectly errors when using autoAllocateChunkSize #41886
Labels
Comments
@MattiasBuelens wdyt? |
@benjamingr I commented in #41887 (review). Looks like a bug in Node's implementation, which is unfortunately not covered by WPT currently. We should definitely add a test to WPT for this. 👍 |
Merged
3 tasks
bengl
pushed a commit
to bengl/node
that referenced
this issue
Feb 21, 2022
Fixes: nodejs#41886 PR-URL: nodejs#41887 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
bengl
pushed a commit
to bengl/node
that referenced
this issue
Feb 21, 2022
Fixes: nodejs#41886 PR-URL: nodejs#41887 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams
pushed a commit
to danielleadams/node
that referenced
this issue
Apr 21, 2022
Fixes: nodejs#41886 PR-URL: nodejs#41887 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
v16.13.2
Platform
Darwin Seans-MacBook-Pro.local 21.2.0 Darwin Kernel Version 21.2.0: Sun Nov 28 20:28:41 PST 2021; root:xnu-8019.61.5~1/RELEASE_ARM64_T6000 arm64
Subsystem
No response
What steps will reproduce the bug?
How often does it reproduce? Is there a required condition?
Reproduces everytime, it is dependent on using the autoAllocateChunkSize and NOT using a BYOB reader on the stream.
What is the expected behavior?
I expect no error. By the spec (https://streams.spec.whatwg.org/#rs-byob-request-prototype) it should allowed respond with a new view as long as the underlying buffer is the same as the original view. I don't see a mention of this method being specifically only for BYOB readers and not autoAllocated buffers.
Not that this works without error on Chrome (only browser that currently supports byte streams): https://jsfiddle.net/w1jb7rq2/1/
What do you see instead?
Additional information
This is due to readableByteStreamControllerPullSteps missing bufferByteLength in the desc added to pendingPullIntos
The text was updated successfully, but these errors were encountered: