Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CJS/ESM toggle broken on mobile #43468

Closed
Nit-nit opened this issue Jun 18, 2022 · 10 comments · Fixed by #43506
Closed

CJS/ESM toggle broken on mobile #43468

Nit-nit opened this issue Jun 18, 2022 · 10 comments · Fixed by #43506
Labels
confirmed-bug Issues with confirmed bugs. doc Issues and PRs related to the documentations.

Comments

@Nit-nit
Copy link

Nit-nit commented Jun 18, 2022

What is the problem this feature will solve?

this feature will remove the logo from above the code for better visibility, oof this is giving me eye strain.

Screenshot_2022-06-18-14-13-48-554_com android chrome

What is the feature you are proposing to solve the problem?

you can make your site better with some little changes in ui/ux

What alternatives have you considered?

turning on desktop site
@Nit-nit Nit-nit added the feature request Issues that request new features to be added to Node.js. label Jun 18, 2022
@Nit-nit Nit-nit changed the title ui/ux could you make your ui/ux a little better? Jun 18, 2022
@aduh95 aduh95 changed the title could you make your ui/ux a little better? CJS/ESM toggle broken on mobile Jun 18, 2022
@aduh95 aduh95 added doc Issues and PRs related to the documentations. android Issues and PRs related to the android platform. and removed feature request Issues that request new features to be added to Node.js. labels Jun 18, 2022
@aduh95
Copy link
Contributor

aduh95 commented Jun 18, 2022

What is the browser you are using? I cannot reproduce on iOS.

Would you be interested in sending a PR to fix that?

@LiviaMedeiros
Copy link
Contributor

Confirming this on Google Chrome 102.0.5005.78 on Android.

Additionally, horizontal scroll doesn't help (perhaps it should have position:fixed in dedicated place?).

Long screenshot

Screenshot_20220618-181951

@LiviaMedeiros LiviaMedeiros added the confirmed-bug Issues with confirmed bugs. label Jun 18, 2022
@F3n67u
Copy link
Member

F3n67u commented Jun 18, 2022 •
edited

I can reproduce it on the iOS firefox browser.

Long screenshot

36BD8991-A7D1-4BB8-A633-91843A2EAC2E

@LiviaMedeiros LiviaMedeiros removed the android Issues and PRs related to the android platform. label Jun 18, 2022
@F3n67u
Copy link
Member

F3n67u commented Jun 18, 2022

I found another problem in light mode, CJS/ESM toggle will be covered by the code snippet.

image

Long screenshot image

@F3n67u
Copy link
Member

F3n67u commented Jun 18, 2022 •
edited

I could reproduce the above 2 problems using desktop Chrome responsive design mode. I think those problems are not device-specific.

  1. Open desktop Chrome
  2. Open Chrome devtool, and switch to responsive design mode.
  3. Click the "Toggle the dark/light mode" button on the doc site, and you will reproduce the above problems.

@Nit-nit
Copy link
Author

Nit-nit commented Jun 19, 2022

What is the browser you are using? I cannot reproduce on iOS.

Would you be interested in sending a PR to fix that?

i cannot make a PR sorry about that, i couldnt even make my github website design good

@MoLow
Copy link
Member

MoLow commented Jun 19, 2022

I'l try handling this

@MoLow MoLow mentioned this issue Jun 19, 2022
Closed
aduh95 added a commit to aduh95/node that referenced this issue Jun 20, 2022
@aduh95
tools: fix CJS/ESM toggle on small screens
27f1b20 
Fixes: nodejs#43468
aduh95 added a commit to aduh95/node that referenced this issue Jun 20, 2022
@aduh95 @MoLow
tools: fix CJS/ESM toggle on small screens
dbd9385 
Fixes: nodejs#43468
Co-authored-by: Moshe Atlow <moshe@atlow.co.il>
@aduh95 aduh95 mentioned this issue Jun 20, 2022
Merged
aduh95 added a commit that referenced this issue Jun 27, 2022
@aduh95 @MoLow
tools: fix CJS/ESM toggle on small screens
7cbcc4f 
PR-URL: #43506
Co-authored-by: Moshe Atlow <moshe@atlow.co.il>
Fixes: #43468
Reviewed-By: LiviaMedeiros <livia@cirno.name>
targos pushed a commit that referenced this issue Jul 12, 2022
@aduh95 @MoLow @targos
tools: fix CJS/ESM toggle on small screens
8d14d6e 
PR-URL: #43506
Co-authored-by: Moshe Atlow <moshe@atlow.co.il>
Fixes: #43468
Reviewed-By: LiviaMedeiros <livia@cirno.name>
targos pushed a commit that referenced this issue Jul 20, 2022
@aduh95 @MoLow @targos
tools: fix CJS/ESM toggle on small screens
646f161 
PR-URL: #43506
Co-authored-by: Moshe Atlow <moshe@atlow.co.il>
Fixes: #43468
Reviewed-By: LiviaMedeiros <livia@cirno.name>
@Nit-nit
Copy link
Author

Nit-nit commented Jul 24, 2022

Sorry to say but it's still not fixed
Screenshot_20220724-114657.png

@LiviaMedeiros
Copy link
Contributor

7cbcc4f wasn't included in any release yet. The documentation pages on website are built independently for each version, and upcoming releases will have the fix included.
"Live" doc builds can be checked out via GHA artifacts, e.g. this one for current main (d63a4cb).

@aduh95
Copy link
Contributor

aduh95 commented Jul 24, 2022

It was included in v18.16.0, it hasn't landed yet on v16.x though.

targos pushed a commit that referenced this issue Jul 31, 2022
@aduh95 @MoLow @targos
tools: fix CJS/ESM toggle on small screens
a5089c9 
PR-URL: #43506
Co-authored-by: Moshe Atlow <moshe@atlow.co.il>
Fixes: #43468
Reviewed-By: LiviaMedeiros <livia@cirno.name>
guangwong pushed a commit to noslate-project/node that referenced this issue Oct 10, 2022
@aduh95 @MoLow @guangwong
tools: fix CJS/ESM toggle on small screens
83ed5cf 
PR-URL: nodejs/node#43506
Co-authored-by: Moshe Atlow <moshe@atlow.co.il>
Fixes: nodejs/node#43468
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed-bug Issues with confirmed bugs. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
5 participants
@MoLow @F3n67u @aduh95 @LiviaMedeiros @Nit-nit