Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test-perf-hooks-histogram #43503

Closed
F3n67u opened this issue Jun 20, 2022 · 0 comments · Fixed by #43567
Closed

Investigate flaky test-perf-hooks-histogram #43503

F3n67u opened this issue Jun 20, 2022 · 0 comments · Fixed by #43567
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.

Comments

@F3n67u
Copy link
Member

F3n67u commented Jun 20, 2022

Test

test-perf-hooks-histogram

Platform

macos

Console output

Path: parallel/test-perf-hooks-histogram
Error: --- stderr ---
node:internal/event_target:915
  process.nextTick(() => { throw err; });
                           ^
AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
  ok(data.count > 0)
    at MessagePort.<anonymous> (/Users/runner/work/node/node/test/parallel/test-perf-hooks-histogram.js:87:5)
    at MessagePort.<anonymous> (/Users/runner/work/node/node/test/common/index.js:438:15)
    at MessagePort.eventHandler (node:internal/event_target:925:12)
    at [nodejs.internal.kHybridDispatch] (node:internal/event_target:645:20)
    at exports.emitMessage (node:internal/per_context/messageport:23:28) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: false,
  expected: true,
  operator: '=='
}
Node.js v19.0.0-pre
Command: out/Release/node /Users/runner/work/node/node/test/parallel/test-perf-hooks-histogram.js

Build links

https://github.com/nodejs/node/runs/6958868851?check_suite_focus=true

Additional information

This flaky test has reported at #42477
@F3n67u F3n67u added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Jun 20, 2022
santigimeno added a commit to santigimeno/node that referenced this issue Jun 25, 2022
@santigimeno
test: fix flaky test-perf-hooks-histogram
775a957 
Make sure the histogram containing event loop delay info is posted only
when at least one datapoint is collected.

Fixes: nodejs#43503
santigimeno added a commit to santigimeno/node that referenced this issue Jun 25, 2022
@santigimeno
test: fix flaky test-perf-hooks-histogram
f62f7bf 
Make sure the histogram containing event loop delay info is posted only
when at least one datapoint is collected.

Fixes: nodejs#43503
@santigimeno santigimeno mentioned this issue Jun 25, 2022
Merged
nodejs-github-bot pushed a commit that referenced this issue Jul 4, 2022
@santigimeno
test: fix flaky test-perf-hooks-histogram
fd1e39f 
Make sure the histogram containing event loop delay info is posted only
when at least one datapoint is collected.

Fixes: #43503

PR-URL: #43567
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue Jul 12, 2022
@santigimeno @targos
test: fix flaky test-perf-hooks-histogram
2adf4e7 
Make sure the histogram containing event loop delay info is posted only
when at least one datapoint is collected.

Fixes: #43503

PR-URL: #43567
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue Jul 20, 2022
@santigimeno @targos
test: fix flaky test-perf-hooks-histogram
bfcd7f0 
Make sure the histogram containing event loop delay info is posted only
when at least one datapoint is collected.

Fixes: #43503

PR-URL: #43567
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue Jul 31, 2022
@santigimeno @targos
test: fix flaky test-perf-hooks-histogram
9bc4ad0 
Make sure the histogram containing event loop delay info is posted only
when at least one datapoint is collected.

Fixes: #43503

PR-URL: #43567
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this issue Oct 10, 2022
@santigimeno @guangwong
test: fix flaky test-perf-hooks-histogram
579fae8 
Make sure the histogram containing event loop delay info is posted only
when at least one datapoint is collected.

Fixes: nodejs/node#43503

PR-URL: nodejs/node#43567
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix flaky test-perf-hooks-histogram santigimeno/node
1 participant
@F3n67u