Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action lack permission to get pr info #45163

Closed
gengjiawen opened this issue Oct 25, 2022 · 2 comments · Fixed by #45185
Closed

action lack permission to get pr info #45163

gengjiawen opened this issue Oct 25, 2022 · 2 comments · Fixed by #45185

Comments

@gengjiawen
Copy link
Member

gengjiawen commented Oct 25, 2022

https://github.com/nodejs/node/actions/runs/3318923655/jobs/5483440392

- Starting PR CI job
(node:[18](https://github.com/nodejs/node/actions/runs/3318923655/jobs/5483440392#step:6:19)70) [https://github.com/node-fetch/node-fetch/issues/1167] DeprecationWarning: form-data doesn't follow the spec and requires special treatment. Use alternative package
(Use `node --trace-deprecation ...` to show where the warning was created)
✔  PR CI job successfully started

[DEBUG] Error: GraphQL request Error: This endpoint requires you to be authenticated.
    at Request.query (file:///opt/hostedtoolcache/node/16.17.1/x64/lib/node_modules/node-core-utils/lib/request.js:1[19](https://github.com/nodejs/node/actions/runs/3318923655/jobs/5483440392#step:6:20):19)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async Request.gql (file:///opt/hostedtoolcache/node/16.17.1/x64/lib/node_modules/node-core-utils/lib/request.js:69:22)
    at async PRData.getPR (file:///opt/hostedtoolcache/node/16.17.1/x64/lib/node_modules/node-core-utils/lib/pr_data.js:80:[20](https://github.com/nodejs/node/actions/runs/3318923655/jobs/5483440392#step:6:21))
    at async RunPRJob.start (file:///opt/hostedtoolcache/node/16.17.1/x64/lib/node_modules/node-core-utils/lib/ci/run_ci.js:94:7) {
  data: { variables: { prid: 45162, owner: 'nodejs', repo: 'node' } }
}

cc @nodejs/actions

@Trott
Copy link
Member

Trott commented Oct 25, 2022

@nodejs/actions

@richardlau
Copy link
Member

From the stack trace this is likely to be a new required permission after nodejs/node-core-utils#652. We're not passing a valid GitHub token to node-core-utils in the auto-start-ci workflow:

ncu-config set token none

Opened #45185.

nodejs-github-bot pushed a commit that referenced this issue Oct 26, 2022
Recent changes to node-core-utils attempt to read pull request labels
when deciding whether or not to start a V8 CI. This requires a valid
GitHub token with appropriate permissions to be set for node-core-utils.

Refs: nodejs/node-core-utils#652
PR-URL: #45185
Fixes: #45163
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
RafaelGSS pushed a commit that referenced this issue Nov 1, 2022
Recent changes to node-core-utils attempt to read pull request labels
when deciding whether or not to start a V8 CI. This requires a valid
GitHub token with appropriate permissions to be set for node-core-utils.

Refs: nodejs/node-core-utils#652
PR-URL: #45185
Fixes: #45163
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
RafaelGSS pushed a commit that referenced this issue Nov 10, 2022
Recent changes to node-core-utils attempt to read pull request labels
when deciding whether or not to start a V8 CI. This requires a valid
GitHub token with appropriate permissions to be set for node-core-utils.

Refs: nodejs/node-core-utils#652
PR-URL: #45185
Fixes: #45163
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams pushed a commit that referenced this issue Dec 30, 2022
Recent changes to node-core-utils attempt to read pull request labels
when deciding whether or not to start a V8 CI. This requires a valid
GitHub token with appropriate permissions to be set for node-core-utils.

Refs: nodejs/node-core-utils#652
PR-URL: #45185
Fixes: #45163
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams pushed a commit that referenced this issue Dec 30, 2022
Recent changes to node-core-utils attempt to read pull request labels
when deciding whether or not to start a V8 CI. This requires a valid
GitHub token with appropriate permissions to be set for node-core-utils.

Refs: nodejs/node-core-utils#652
PR-URL: #45185
Fixes: #45163
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams pushed a commit that referenced this issue Jan 3, 2023
Recent changes to node-core-utils attempt to read pull request labels
when deciding whether or not to start a V8 CI. This requires a valid
GitHub token with appropriate permissions to be set for node-core-utils.

Refs: nodejs/node-core-utils#652
PR-URL: #45185
Fixes: #45163
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants