Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add GitHub token to auto-start-ci workflow #45185

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

richardlau
Copy link
Member

Recent changes to node-core-utils attempt to read pull request labels when deciding whether or not to start a V8 CI. This requires a valid GitHub token with appropriate permissions to be set for node-core-utils.

Fixes: #45163
Refs: nodejs/node-core-utils#652


Untested -- change based on

ncu-config set token "${{ secrets.GH_USER_TOKEN }}"
. I think secrets.JENKINS_USER and secrets.GH_USER_NAME are the same (since we use GitHub auth in our Jenkins server).

Recent changes to node-core-utils attempt to read pull request labels
when deciding whether or not to start a V8 CI. This requires a valid
GitHub token with appropriate permissions to be set for node-core-utils.

Refs: nodejs/node-core-utils#652
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 25, 2022
@gengjiawen gengjiawen added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 26, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @gengjiawen. Please 👍 to approve.

@gengjiawen gengjiawen added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 26, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 26, 2022
@nodejs-github-bot nodejs-github-bot merged commit 5e2aeae into nodejs:main Oct 26, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 5e2aeae

@richardlau richardlau deleted the startciperms branch October 26, 2022 17:17
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
Recent changes to node-core-utils attempt to read pull request labels
when deciding whether or not to start a V8 CI. This requires a valid
GitHub token with appropriate permissions to be set for node-core-utils.

Refs: nodejs/node-core-utils#652
PR-URL: #45185
Fixes: #45163
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
Recent changes to node-core-utils attempt to read pull request labels
when deciding whether or not to start a V8 CI. This requires a valid
GitHub token with appropriate permissions to be set for node-core-utils.

Refs: nodejs/node-core-utils#652
PR-URL: #45185
Fixes: #45163
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
Recent changes to node-core-utils attempt to read pull request labels
when deciding whether or not to start a V8 CI. This requires a valid
GitHub token with appropriate permissions to be set for node-core-utils.

Refs: nodejs/node-core-utils#652
PR-URL: #45185
Fixes: #45163
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
Recent changes to node-core-utils attempt to read pull request labels
when deciding whether or not to start a V8 CI. This requires a valid
GitHub token with appropriate permissions to be set for node-core-utils.

Refs: nodejs/node-core-utils#652
PR-URL: #45185
Fixes: #45163
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
Recent changes to node-core-utils attempt to read pull request labels
when deciding whether or not to start a V8 CI. This requires a valid
GitHub token with appropriate permissions to be set for node-core-utils.

Refs: nodejs/node-core-utils#652
PR-URL: #45185
Fixes: #45163
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

action lack permission to get pr info
5 participants