Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test.parallel/test-fs-watch-recursive #45535

Closed
anonrig opened this issue Nov 20, 2022 · 2 comments · Fixed by #45865
Closed

Investigate flaky test.parallel/test-fs-watch-recursive #45535

anonrig opened this issue Nov 20, 2022 · 2 comments · Fixed by #45865
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.

Comments

@anonrig
Copy link
Member

anonrig commented Nov 20, 2022 •
edited

Test

test.parallel/test-fs-watch-recursive

Platform

No response

Console output

Timeout

Build links

Linux:

macOS:

Additional information

No response
@anonrig anonrig added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Nov 20, 2022
@anonrig anonrig mentioned this issue Nov 20, 2022
Closed
@ywave620
Copy link
Contributor

Could we mark it as flaky since it is causing many CI red

@bnoordhuis
Copy link
Member

It's failing a lot on different operating systems lately. The non-recursive version acted up in the past too, see #40728.

The file is really a bunch of different tests packed together. I want to suggest splitting them into separate files and marking them flaky individually.

@anonrig anonrig mentioned this issue Dec 14, 2022
Merged
nodejs-github-bot pushed a commit that referenced this issue Dec 20, 2022
@anonrig
test: split parallel fs-watch-recursive tests
8398f85 
PR-URL: #45865
Fixes: #45535
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this issue Jan 1, 2023
@anonrig @targos
test: split parallel fs-watch-recursive tests
e6da353 
PR-URL: #45865
Fixes: #45535
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this issue Jan 4, 2023
@anonrig @RafaelGSS
test: split parallel fs-watch-recursive tests
dd0ac7c 
PR-URL: #45865
Fixes: #45535
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this issue Jan 5, 2023
@anonrig @RafaelGSS
test: split parallel fs-watch-recursive tests
c6c0947 
PR-URL: #45865
Fixes: #45535
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
juanarbol pushed a commit that referenced this issue Jan 26, 2023
@anonrig @juanarbol
test: split parallel fs-watch-recursive tests
57e9ab1 
PR-URL: #45865
Fixes: #45535
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
cheungxi pushed a commit to cheungxi/node that referenced this issue Feb 1, 2023
@anonrig @cheungxi
test: split parallel fs-watch-recursive tests
fab102f 
PR-URL: nodejs#45865
Fixes: nodejs#45535
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.
Projects
None yet
Milestone
No milestone
3 participants
@bnoordhuis @anonrig @ywave620