-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: split parallel fs-watch-recursive tests #45865
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
anonrig:test.parallel/test-fs-watch-recursive
Dec 20, 2022
Merged
test: split parallel fs-watch-recursive tests #45865
nodejs-github-bot
merged 1 commit into
nodejs:main
from
anonrig:test.parallel/test-fs-watch-recursive
Dec 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
reviewed
Dec 14, 2022
test/parallel/test-fs-watch-recursive-add-file-to-existing-subfolder.js
Outdated
Show resolved
Hide resolved
test/parallel/test-fs-watch-recursive-add-file-to-new-folder.js
Outdated
Show resolved
Hide resolved
194c82f
to
6f81a76
Compare
6f81a76
to
00dbd16
Compare
13 tasks
aduh95
approved these changes
Dec 17, 2022
targos
approved these changes
Dec 17, 2022
12 tasks
14 tasks
jasnell
approved these changes
Dec 19, 2022
lpinca
approved these changes
Dec 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
14 tasks
Landed in 8398f85 |
This was referenced Dec 21, 2022
Merged
Merged
CI does not seem to like this for v18.x in Linux jobs, see https://ci.nodejs.org/job/node-test-pull-request/49261/ |
cheungxi
pushed a commit
to cheungxi/node
that referenced
this pull request
Feb 1, 2023
PR-URL: nodejs#45865 Fixes: nodejs#45535 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-requested-v18.x
PRs awaiting manual backport to the v18.x-staging branch.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split
test-fs-watch-recursive
for a better understanding of the failing ones.Fixes: #45535
CC @bnoordhuis