Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add riscv64 to the list of supported architectures #49278

Closed
ilg-ul opened this issue Aug 22, 2023 · 5 comments · Fixed by #49284
Closed

Add riscv64 to the list of supported architectures #49278

ilg-ul opened this issue Aug 22, 2023 · 5 comments · Fixed by #49284
Assignees
Labels
doc Issues and PRs related to the documentations. os Issues and PRs related to the os subsystem. process Issues and PRs related to the process subsystem. riscv64 Issues and PRs related to the riscv64 architecture.

Comments

@ilg-ul
Copy link
Contributor

ilg-ul commented Aug 22, 2023

Affected URL(s)

https://nodejs.org/dist/latest-v20.x/docs/api/os.html#osarch

Description of the problem

The node.git/doc/api/os.md file currently reads:

Returns the operating system CPU architecture for which the Node.js binary was
compiled. Possible values are `'arm'`, `'arm64'`, `'ia32'`, `'mips'`,
`'mipsel'`, `'ppc'`, `'ppc64'`, `'s390'`, `'s390x'`, and `'x64'`.

I suggest to change it to:

Returns the operating system CPU architecture for which the Node.js binary was
compiled. Possible values are `'arm'`, `'arm64'`, `'ia32'`, `'mips'`,
`'mipsel'`, `'ppc'`, `'ppc64'`, `'riscv64'`, `'s390'`, `'s390x'`, and `'x64'`.

The same for node.git/doc/api/process.md.

@ilg-ul ilg-ul added the doc Issues and PRs related to the documentations. label Aug 22, 2023
@VoltrexKeyva VoltrexKeyva added os Issues and PRs related to the os subsystem. process Issues and PRs related to the process subsystem. labels Aug 22, 2023
sxa added a commit to sxa/node that referenced this issue Aug 22, 2023
PR-URL: nodejs#49278

Signed-off-by: Stewart X Addison <sxa@redhat.com>
@sxa sxa self-assigned this Aug 22, 2023
@sxa
Copy link
Member

sxa commented Aug 22, 2023

Well spotted - thanks.
PR raised

@ilg-ul
Copy link
Contributor Author

ilg-ul commented Aug 22, 2023

Any idea when the RISC-V binaries will be promoted from the unofficial section to first class citizens?

@sxa
Copy link
Member

sxa commented Aug 22, 2023

I don't think anyone's really been pushing for it but as long as we have someone willing to stand up to fix any issues there isn't too much blocking it.

To be honest the main reason I haven't personally pushed it forward is because we haven't fixed the fact it's building openssl without assembler optimisation. I'm fairly certain it's not a hard fix but I haven't been able to justify spending time on it (yet) :-) We'd also need to check if there are any outstanding issues with the tests (other than any related to the openssl options)

I do run a Node web server at home on a MangoPi D1 though and it seems to have been reliable enough though...

@ilg-ul
Copy link
Contributor Author

ilg-ul commented Aug 22, 2023

I tried a build via the nvm scripts, and I noticed that the openssl selected the wrong architecture.

I'll try to take a look at this in the near future, but I currently have only a QEMU machine to experiment with.

Can you point me to the scripts used to build the unofficial binaries?

@richardlau
Copy link
Member

Can you point me to the scripts used to build the unofficial binaries?

https://github.com/nodejs/unofficial-builds/tree/main/recipes/riscv64

@richardlau richardlau added the riscv64 Issues and PRs related to the riscv64 architecture. label Aug 22, 2023
aduh95 pushed a commit that referenced this issue Aug 26, 2023
PR-URL: #49284

Signed-off-by: Stewart X Addison <sxa@redhat.com>
Fixes: #49278
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon pushed a commit that referenced this issue Sep 10, 2023
PR-URL: #49284

Signed-off-by: Stewart X Addison <sxa@redhat.com>
Fixes: #49278
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
alexfernandez pushed a commit to alexfernandez/node that referenced this issue Nov 1, 2023
PR-URL: nodejs#49284

Signed-off-by: Stewart X Addison <sxa@redhat.com>
Fixes: nodejs#49278
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. os Issues and PRs related to the os subsystem. process Issues and PRs related to the process subsystem. riscv64 Issues and PRs related to the riscv64 architecture.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants