Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky GC-related tests with V8 12.2 #52273

Open
targos opened this issue Mar 30, 2024 · 2 comments
Open

Flaky GC-related tests with V8 12.2 #52273

targos opened this issue Mar 30, 2024 · 2 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. v8 engine Issues and PRs related to the V8 dependency.

Comments

@targos
Copy link
Member

targos commented Mar 30, 2024 •
edited

re. test-shadow-realm-gc-module and test-shadow-realm-gc, I think we should just skip them. Possible solution can be, use the more reliable checkIfCollectableByCounting() to check if the ShadowRealm instance in the main context can be collected, but I feel that would make the test invalid too (e.g. the native side can still be leaking even though the JS instances are collectable), so we might as well just skip and figure out a better way to test it later.

re. test-net-write-fully-async-hex-string, looks like it's related to --expose-gc again. I'd suggest that we just open an issue to track this and the shadow realm tests, and skip them for now. They are likely flaking due to incorrect assumptions in the tests broken by V8's new GC strategy, not real bugs.

Originally posted by @joyeecheung in #51362 (comment)
targos added a commit to targos/node that referenced this issue Mar 30, 2024
@targos
test: mark some GC-related tests as flaky
d8b04a9 
Refs: nodejs#52273
targos added a commit that referenced this issue Mar 31, 2024
@targos
test: mark some GC-related tests as flaky
84c2e71 
Refs: #52273
PR-URL: #51362
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@joyeecheung
Copy link
Member

joyeecheung commented Mar 31, 2024 •
edited

Not sure if it's exactly related to test-net-write-fully-async-hex-string, but just something I notice: I discovered in my Oilpan migration prototypes that we may be under reporting externally-managed memory (#40786 (comment)), leading to poor GC performance.

@RedYetiDev RedYetiDev added flaky-test Issues and PRs related to the tests with unstable failures on the CI. v8 engine Issues and PRs related to the V8 dependency. labels Apr 20, 2024
@mhdawson
Copy link
Member

mhdawson commented May 2, 2024

@legendecas an FYI as I think you were working on shadow realm related stuff?

@legendecas legendecas mentioned this issue May 6, 2024
Merged
nodejs-github-bot pushed a commit that referenced this issue May 8, 2024
@legendecas
test: skip unstable shadow realm gc tests
1291d3d 
PR-URL: #52855
Refs: #52273
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
targos pushed a commit that referenced this issue May 11, 2024
@legendecas @targos
test: skip unstable shadow realm gc tests
5e731da 
PR-URL: #52855
Refs: #52273
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@targos @joyeecheung @mhdawson @RedYetiDev