Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate flaky test-preload.js #6722

Closed
Trott opened this issue May 12, 2016 · 6 comments
Closed

Investigate flaky test-preload.js #6722

Trott opened this issue May 12, 2016 · 6 comments
Labels
test Issues and PRs related to the tests.

Comments

@Trott
Copy link
Member

Trott commented May 12, 2016

  • Version: master branch
  • Platform: CentOS 5, 32-bit
  • Subsystem: module?

Failure in CI:
https://ci.nodejs.org/job/node-test-commit-linux/3349/nodes=centos5-32/tapTestReport/test.tap-677/

/cc @bmeck

@Trott Trott added the test Issues and PRs related to the tests. label May 12, 2016
@Trott
Copy link
Member Author

Trott commented May 12, 2016

/cc @nodejs/testing

@Trott
Copy link
Member Author

Trott commented May 12, 2016

/cc @Fishrock123

@Fishrock123
Copy link
Member

Not sure why we now have 3 issues open, so I'll close the AIX one. PR (WIP now): #6718

Trott added a commit to Trott/io.js that referenced this issue May 13, 2016
Use `close` event rather than `exit` event to make sure all output has
been received before checking assertions.

Fixes: nodejs#6722
@Fishrock123
Copy link
Member

Here's a new one:

https://ci.nodejs.org/job/node-test-commit-linux/3370/nodes=centos7-64/tapTestReport/test.tap-676/ from #5958

# 
# assert.js:90
# throw new assert.AssertionError({
# ^
# AssertionError: '' == 'A\n> '
# at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/nodes/centos7-64/test/parallel/test-preload.js:106:10)
# at emitTwo (events.js:106:13)
# at ChildProcess.emit (events.js:191:7)
# at Process.ChildProcess._handle.onexit (internal/child_process.js:204:12)

Haven't seen this output before.

@jasnell
Copy link
Member

jasnell commented May 13, 2016

And another (also centos7-64):

https://ci.nodejs.org/job/node-test-commit-linux/3379/nodes=centos7-64/console

not ok 678 test-preload.js
# 
# assert.js:90
#   throw new assert.AssertionError({
#   ^
# AssertionError: '' == 'A\nhello\n'
#     at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/nodes/centos7-64/test/parallel/test-preload.js:86:10)
#     at emitTwo (events.js:106:13)
#     at ChildProcess.emit (events.js:191:7)
#     at Process.ChildProcess._handle.onexit (internal/child_process.js:204:12)
  ---
  duration_ms: 0.463

@Trott Trott closed this as completed in b5a75ba May 13, 2016
evanlucas pushed a commit that referenced this issue May 17, 2016
Use `close` event rather than `exit` event to make sure all output has
been received before checking assertions.

PR-URL: #6728
Fixes: #6722
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
bmeck pushed a commit to bmeck/node that referenced this issue Aug 30, 2016
Use `close` event rather than `exit` event to make sure all output has
been received before checking assertions.

Fixes: nodejs#6722
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants