tools: enforce linting for unix-style line endings #6685
Conversation
|
LGTM |
1 similar comment
|
LGTM |
| @@ -59,6 +59,7 @@ rules: | |||
| indent: [2, 2, {SwitchCase: 1}] | |||
| key-spacing: [2, {mode: "minimum"}] | |||
| keyword-spacing: 2 | |||
| linebreak-style: 2 | |||
There was a problem hiding this comment.
Just curious, isn't it normally written as linebreak-style: "unix"?
There was a problem hiding this comment.
It should actually be linebreak-style: [2, "unix"].
There was a problem hiding this comment.
"unix" is the default so just enabling it with 2 is enough. However, if explicitness is desired, I'm happy to change it to [2, "unix"].
There was a problem hiding this comment.
Yes, please be explicit. If they ever change the default, we'd be screwed. 😆
Also, it's easier to understand for someone unfamiliar with ESLint's defaults.
There was a problem hiding this comment.
Edited to be explicit about the unix option, rebased, force pushed.
|
LGTM |
|
LGTM once #6685 (comment) is addressed. |
|
LGTM |
|
Two CI failures are a known flaky and a buildbot failure. Landing... |
PR-URL: nodejs#6685 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
|
Landed in 517b892 |
PR-URL: #6685 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
Checklist
Affected core subsystem(s)
tools
Description of change