Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: enforce linting for unix-style line endings #6685

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 11, 2016

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

tools

Description of change

@Trott Trott added the tools Issues and PRs related to the tools directory. label May 11, 2016
@targos
Copy link
Member

targos commented May 11, 2016

LGTM

1 similar comment
@jbergstroem
Copy link
Member

LGTM

@@ -59,6 +59,7 @@ rules:
indent: [2, 2, {SwitchCase: 1}]
key-spacing: [2, {mode: "minimum"}]
keyword-spacing: 2
linebreak-style: 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, isn't it normally written as linebreak-style: "unix"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should actually be linebreak-style: [2, "unix"].

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"unix" is the default so just enabling it with 2 is enough. However, if explicitness is desired, I'm happy to change it to [2, "unix"].

Copy link
Contributor

@silverwind silverwind May 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please be explicit. If they ever change the default, we'd be screwed. 😆

Also, it's easier to understand for someone unfamiliar with ESLint's defaults.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited to be explicit about the unix option, rebased, force pushed.

@jasnell
Copy link
Member

jasnell commented May 11, 2016

LGTM

@silverwind
Copy link
Contributor

LGTM once #6685 (comment) is addressed.

@bnoordhuis
Copy link
Member

LGTM

@Trott
Copy link
Member Author

Trott commented May 13, 2016

@Trott
Copy link
Member Author

Trott commented May 13, 2016

Two CI failures are a known flaky and a buildbot failure. Landing...

Trott added a commit to Trott/io.js that referenced this pull request May 13, 2016
PR-URL: nodejs#6685
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
@Trott
Copy link
Member Author

Trott commented May 13, 2016

Landed in 517b892

@Trott Trott closed this May 13, 2016
evanlucas pushed a commit that referenced this pull request May 17, 2016
PR-URL: #6685
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
@Trott Trott deleted the rn branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants