Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whitelist dotfiles instead of blacklisting? #8012

Closed
claudiorodriguez opened this issue Aug 8, 2016 · 5 comments
Closed

Whitelist dotfiles instead of blacklisting? #8012

claudiorodriguez opened this issue Aug 8, 2016 · 5 comments
Labels
meta Issues and PRs related to the general management of the project. question Issues that look for answers.

Comments

@claudiorodriguez
Copy link
Contributor

I was wondering, after seeing a new PR that adds .idea to the .gitignore, and actually taking a look at the file - seeing as how so many people with so many different IDEs and tools which generate dotfiles contribute to node, wouldn't it make more sense to whitelist the dotfiles that we want git to version, and blacklist all others? Or would this break something I'm not aware of?

I mean something like

.*
!.editorconfig
!.eslintignore
!.eslintrc
!.gitattributes
!.etc etc
@silverwind
Copy link
Contributor

I like that approach, +1.

@jasnell
Copy link
Member

jasnell commented Aug 8, 2016

Definitely seems reasonable to me.

@mscdex mscdex added question Issues that look for answers. meta Issues and PRs related to the general management of the project. labels Aug 8, 2016
@Fishrock123
Copy link
Member

Might be a good idea at this point..

@claudiorodriguez
Copy link
Contributor Author

I'll delve into the current dotfiles and work on a PR then

@jasnell jasnell mentioned this issue Aug 8, 2016
Closed
1 task
@claudiorodriguez claudiorodriguez mentioned this issue Aug 8, 2016
Closed
1 task
@claudiorodriguez
Copy link
Contributor Author

I've created the PR, please let me know if I'm missing any trackable dotfile

claudiorodriguez added a commit to claudiorodriguez/node that referenced this issue Aug 9, 2016
@claudiorodriguez
meta: whitelist dotfiles in .gitignore
7dc9f9a 
Instead of excluding IDE-specific dotfiles, exclude all and
then whitelist those the project needs to track.

Fixes: nodejs#8012
addaleax pushed a commit that referenced this issue Dec 5, 2016
@claudiorodriguez @addaleax
meta: whitelist dotfiles in .gitignore
3253954 
Instead of excluding IDE-specific dotfiles, exclude all and
then whitelist those the project needs to track.

Refs: #8010
Refs: #9111
Refs: #10052

Fixes: #8012
PR-URL: #8016

Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
jmdarling pushed a commit to jmdarling/node that referenced this issue Dec 8, 2016
@claudiorodriguez
meta: whitelist dotfiles in .gitignore
96ade1f 
Instead of excluding IDE-specific dotfiles, exclude all and
then whitelist those the project needs to track.

Refs: nodejs#8010
Refs: nodejs#9111
Refs: nodejs#10052

Fixes: nodejs#8012
PR-URL: nodejs#8016

Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
MylesBorins pushed a commit that referenced this issue Dec 20, 2016
@claudiorodriguez @MylesBorins
meta: whitelist dotfiles in .gitignore
65e134f 
Instead of excluding IDE-specific dotfiles, exclude all and
then whitelist those the project needs to track.

Refs: #8010
Refs: #9111
Refs: #10052

Fixes: #8012
PR-URL: #8016

Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
MylesBorins pushed a commit that referenced this issue Dec 20, 2016
@claudiorodriguez @MylesBorins
meta: whitelist dotfiles in .gitignore
0be56cd 
Instead of excluding IDE-specific dotfiles, exclude all and
then whitelist those the project needs to track.

Refs: #8010
Refs: #9111
Refs: #10052

Fixes: #8012
PR-URL: #8016

Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
MylesBorins pushed a commit that referenced this issue Dec 21, 2016
@claudiorodriguez @MylesBorins
meta: whitelist dotfiles in .gitignore
dc2e8a7 
Instead of excluding IDE-specific dotfiles, exclude all and
then whitelist those the project needs to track.

Refs: #8010
Refs: #9111
Refs: #10052

Fixes: #8012
PR-URL: #8016

Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
MylesBorins pushed a commit that referenced this issue Dec 21, 2016
@claudiorodriguez @MylesBorins
meta: whitelist dotfiles in .gitignore
b0cbc76 
Instead of excluding IDE-specific dotfiles, exclude all and
then whitelist those the project needs to track.

Refs: #8010
Refs: #9111
Refs: #10052

Fixes: #8012
PR-URL: #8016

Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project. question Issues that look for answers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

meta: whitelist dotfiles in .gitignore claudiorodriguez/node
5 participants
@mscdex @silverwind @jasnell @Fishrock123 @claudiorodriguez