deps: backport f795a79 from upstream V8 #10386

Closed
wants to merge 1 commit into
from

Projects

None yet

5 participants

@targos
Member
targos commented Dec 21, 2016
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

v8

Description of change

Original commit message:

    Rewrite scopes in computed properties in destructured parameters

    While we properly handled scopes of initializers in destructured
    parameters,
    we never did the right thing for computed properties. This patch
    fixes that
    by factoring out PatternRewriter's scope rewriting logic and calls
    it for the computed property case.

    BUG=chromium:620119

    Review-Url: https://codereview.chromium.org/2084103002
    Cr-Commit-Position: refs/heads/master@{#37228}

Fixes: #10347

@targos targos deps: backport f795a79 from upstream V8
Original commit message:
    Rewrite scopes in computed properties in destructured parameters

    While we properly handled scopes of initializers in destructured
    parameters,
    we never did the right thing for computed properties. This patch
    fixes that
    by factoring out PatternRewriter's scope rewriting logic and calls
    it for the computed property case.

    BUG=chromium:620119

    Review-Url: https://codereview.chromium.org/2084103002
    Cr-Commit-Position: refs/heads/master@{#37228}

Fixes: nodejs#10347
23de4e3
@targos targos added v6.x V8 labels Dec 21, 2016
@MylesBorins
Member

thanks for hunting this down @targos. Will land later today if green

@targos targos added a commit that referenced this pull request Dec 26, 2016
@targos targos deps: backport f795a79 from upstream V8
Original commit message:
    Rewrite scopes in computed properties in destructured parameters

    While we properly handled scopes of initializers in destructured
    parameters,
    we never did the right thing for computed properties. This patch
    fixes that
    by factoring out PatternRewriter's scope rewriting logic and calls
    it for the computed property case.

    BUG=chromium:620119

    Review-Url: https://codereview.chromium.org/2084103002
    Cr-Commit-Position: refs/heads/master@{#37228}

Fixes: #10347
PR-URL: #10386
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
e60cafd
@targos targos added the land-on-v6.x label Dec 26, 2016
@targos
Member
targos commented Dec 26, 2016

Landed in v6.x-staging as e60cafd

@targos targos closed this Dec 26, 2016
@targos targos deleted the targos:v6.x-fix-10347 branch Dec 26, 2016
@MylesBorins MylesBorins referenced this pull request Dec 27, 2016
Merged

V6.9.3 proposal #10394

@MylesBorins MylesBorins added a commit to MylesBorins/node that referenced this pull request Jan 3, 2017
@MylesBorins MylesBorins 2016-01-03, Version 6.9.3 'Boron' (LTS) Release
This LTS release comes with 312 commits. This includes 229 that are
test related, 62 that are docs related, 17 which are build / tools
related, and 4 commits which are updates to dependencies.

Notable Changes:

* build:
  - shared library support is now working for AIX builds
    (Stewart Addison) nodejs#9675
* deps:
    - *npm*: upgrade npm to 3.10.10 (Rebecca Turner)
             nodejs#9847
    - *V8*: Destructuring of arrow function arguments via computed
            property no longer throws (Michaël Zasso)
            nodejs#10386)
* inspector:
  - /json/version returns object, not an object wrapped in an array
    (Ben Noordhuis) nodejs#9762
* module:
  - using --debug-brk and --eval together now works as expected
    (Kelvin Jin) nodejs#8876
* process:
  - improve performance of nextTick up to 20% (Evan Lucas)
    nodejs#8932
* repl:
    - the division operator will no longer be accidentally parsed as
      regex (Teddy Katz) nodejs#10103
    - improved support for generator functions (Teddy Katz)
      nodejs#9852
* timers:
  - Re canceling a cancelled timers will no longer throw
    (Jeremiah Senkpiel) nodejs#9685

PR-URL: nodejs#10394
93a9109
@MylesBorins MylesBorins added a commit that referenced this pull request Jan 3, 2017
@MylesBorins MylesBorins 2017-01-03, Version 6.9.3 'Boron' (LTS) Release
This LTS release comes with 312 commits. This includes 229 that are
test related, 62 that are docs related, 17 which are build / tools
related, and 4 commits which are updates to dependencies.

Notable Changes:

* build:
  - shared library support is now working for AIX builds
    (Stewart Addison) #9675
* deps:
    - *npm*: upgrade npm to 3.10.10 (Rebecca Turner)
             #9847
    - *V8*: Destructuring of arrow function arguments via computed
            property no longer throws (Michaël Zasso)
            #10386)
* inspector:
  - /json/version returns object, not an object wrapped in an array
    (Ben Noordhuis) #9762
* module:
  - using --debug-brk and --eval together now works as expected
    (Kelvin Jin) #8876
* process:
  - improve performance of nextTick up to 20% (Evan Lucas)
    #8932
* repl:
    - the division operator will no longer be accidentally parsed as
      regex (Teddy Katz) #10103
    - improved support for generator functions (Teddy Katz)
      #9852
* timers:
  - Re canceling a cancelled timers will no longer throw
    (Jeremiah Senkpiel) #9685

PR-URL: #10394
42149d7
@MylesBorins MylesBorins added a commit that referenced this pull request Jan 3, 2017
@MylesBorins MylesBorins 2017-01-03, Version 6.9.3 'Boron' (LTS) Release
This LTS release comes with 312 commits. This includes 229 that are
test related, 62 that are docs related, 17 which are build / tools
related, and 4 commits which are updates to dependencies.

Notable Changes:

* build:
  - shared library support is now working for AIX builds
    (Stewart Addison) #9675
* deps:
    - *npm*: upgrade npm to 3.10.10 (Rebecca Turner)
             #9847
    - *V8*: Destructuring of arrow function arguments via computed
            property no longer throws (Michaël Zasso)
            #10386)
* inspector:
  - /json/version returns object, not an object wrapped in an array
    (Ben Noordhuis) #9762
* module:
  - using --debug-brk and --eval together now works as expected
    (Kelvin Jin) #8876
* process:
  - improve performance of nextTick up to 20% (Evan Lucas)
    #8932
* repl:
    - the division operator will no longer be accidentally parsed as
      regex (Teddy Katz) #10103
    - improved support for generator functions (Teddy Katz)
      #9852
* timers:
  - Re canceling a cancelled timers will no longer throw
    (Jeremiah Senkpiel) #9685

PR-URL: #10394
2bf1c24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment