New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: tidy `net` benchmarks #10446

Merged

mscdex merged 2 commits into nodejs:master from mscdex:benchmark-net-tidy

Jan 5, 2017

Contributor

mscdex commented Dec 25, 2016

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

benchmark

Description of change

These commits just tidy things up a bit for the net benchmarks.

mscdex added benchmark net labels

nodejs-github-bot added benchmark lts-watch-v6.x labels

jasnell approved these changes

View reviewed changes

mscdex added 2 commits

January 5, 2017 02:41


          benchmark: move punycode benchmark out of net

d43b144

punycode/ICU is not specific to any particular module, so move it to
a more generic location.

PR-URL: nodejs#10446
Reviewed-By: James M Snell <jasnell@gmail.com>


          benchmark: improve readability of net benchmarks

f955c73

PR-URL: nodejs#10446
Reviewed-By: James M Snell <jasnell@gmail.com>

mscdex force-pushed the benchmark-net-tidy branch from c1ef3df to f955c73 Compare

January 5, 2017 07:42

nodejs-github-bot added the lts-watch-v6.x label

Contributor Author

mscdex commented Jan 5, 2017

Lint: https://ci.nodejs.org/job/node-test-linter/6219/

mscdex merged commit f955c73 into nodejs:master

mscdex deleted the benchmark-net-tidy branch

January 5, 2017 07:49

italoacasas pushed a commit to italoacasas/node that referenced this pull request


          benchmark: move punycode benchmark out of net

f6c94e5

punycode/ICU is not specific to any particular module, so move it to
a more generic location.

PR-URL: nodejs#10446
Reviewed-By: James M Snell <jasnell@gmail.com>

italoacasas pushed a commit to italoacasas/node that referenced this pull request


          benchmark: improve readability of net benchmarks

111e2f8

PR-URL: nodejs#10446
Reviewed-By: James M Snell <jasnell@gmail.com>

italoacasas pushed a commit to italoacasas/node that referenced this pull request


          benchmark: move punycode benchmark out of net

76e9fe3

punycode/ICU is not specific to any particular module, so move it to
a more generic location.

PR-URL: nodejs#10446
Reviewed-By: James M Snell <jasnell@gmail.com>

italoacasas pushed a commit to italoacasas/node that referenced this pull request


          benchmark: improve readability of net benchmarks

91c59a6

PR-URL: nodejs#10446
Reviewed-By: James M Snell <jasnell@gmail.com>

italoacasas pushed a commit to italoacasas/node that referenced this pull request


          benchmark: move punycode benchmark out of net

f6ae848

punycode/ICU is not specific to any particular module, so move it to
a more generic location.

PR-URL: nodejs#10446
Reviewed-By: James M Snell <jasnell@gmail.com>

italoacasas pushed a commit to italoacasas/node that referenced this pull request


          benchmark: improve readability of net benchmarks

f44f913

PR-URL: nodejs#10446
Reviewed-By: James M Snell <jasnell@gmail.com>

italoacasas mentioned this pull request

Proposal to update v7.x-staging #10989

Closed

italoacasas pushed a commit to italoacasas/node that referenced this pull request


          benchmark: move punycode benchmark out of net

d19136d

punycode/ICU is not specific to any particular module, so move it to
a more generic location.

PR-URL: nodejs#10446
Reviewed-By: James M Snell <jasnell@gmail.com>

italoacasas pushed a commit to italoacasas/node that referenced this pull request


          benchmark: improve readability of net benchmarks

372e3ee

PR-URL: nodejs#10446
Reviewed-By: James M Snell <jasnell@gmail.com>

italoacasas mentioned this pull request

v7.5.0 proposal #11062

Merged

MylesBorins pushed a commit that referenced this pull request


          benchmark: improve readability of net benchmarks

deaf3f6

PR-URL: #10446
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          benchmark: improve readability of net benchmarks

0a07d2b

PR-URL: #10446
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added land-on-v4.x and removed lts-watch-v6.x labels

MylesBorins pushed a commit that referenced this pull request


          benchmark: move punycode benchmark out of net

ff905ee

punycode/ICU is not specific to any particular module, so move it to
a more generic location.

PR-URL: #10446
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added the dont-land-on-v4.x label

MylesBorins removed the land-on-v4.x label

MylesBorins pushed a commit that referenced this pull request


          benchmark: improve readability of net benchmarks

06c339d

PR-URL: #10446
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          benchmark: move punycode benchmark out of net

d22d7cc

punycode/ICU is not specific to any particular module, so move it to
a more generic location.

PR-URL: #10446
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins mentioned this pull request

v6.10.1 proposal #11759

Merged

MylesBorins pushed a commit that referenced this pull request


          benchmark: improve readability of net benchmarks

a597c11

PR-URL: #10446
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins mentioned this pull request

v4.8.1 proposal #11760

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment