v6.10.1 proposal #11759
Merged
v6.10.1 proposal #11759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were transporting the heap statistics as uint32 values to JS land but those wrap around for values > 4 GB. Use 64 bits floats instead, those should last us a while. Fixes: #10185 PR-URL: #10186 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
new year new alias PR-URL: #10586 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Remove the numbers from the comments to make it clear that assert does not follow the [CJS spec](http://wiki.commonjs.org/wiki/Unit_Testing/1.0). Additionally, clean up the existing comments for consistent formatting/language and ease of reading. PR-URL: #10579 Fixes: #9063 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
PR-URL: #10446 Reviewed-By: James M Snell <jasnell@gmail.com>
* use const instead of var * use common.mustCall to control functions execution * use assert.strictEqual instead of assert.equal * use arrow functions * remove console.error PR-URL: #10521 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
We have had #9728 open for a while but the frequency of the failures seems to be such that we should mark it as flaky while we continue to investigate. PR-URL: #10618 Reviewed-by: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes: nodejs/CTC#41 PR-URL: #10604 Fixes: https://github.com/nodejs/CTC#41 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Michal Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* Change === to == in one place * Add explanation about another non-strict if-statement PR-URL: #11513 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Modify the `[Writable]` and `[Readable]` links so they point directly to the right sections in the stream.html doc PR-URL: #11517 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Add documentation for http clientRequest.aborted. PR-URL: #11544 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Communicate about leaked globals via `AssertionError` rather than `console.log()`. PR-URL: #11547 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Add a `test-addons-clean` to the Makefile to clean up files generated during testing addons. PR-URL: #11519 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Fixing a typo in comments, the word 'remaining' had a typo. PR-URL: #11503 Fixes: #11491 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* Remove comment referring to the CommonJS Unit Testing 1.0 spec. This module is no longer intended to comply with that spec. * Remove puzzling "THIS IS NOT TESTED NOR LIKELY TO WORK OUTSIDE V8!" comment. No doubt, it made sense at one time. * Favor `===` over `==` in two places. PR-URL: #11511 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The intention of test case is to make sure that `timeout` property is honored and the code in context terminates and throws correct exception. However in test case, the code inside context would complete before `timeout` for windows and would sometimes fail. Updated the code so it guarantee to not complete execution until timeout is triggered. Fixes: #11261 PR-URL: #11530 Reviewed-By: James M Snell <jasnell.gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
The IPC channel is referenced with the message event too. PR-URL: #11494 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
These two functions in the querystring are used as a fallback. To test them, two test cases were added which make errors that will be caught. PR-URL: #11326 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Currently the maximum number of tick is duplicated in two places. This commit introduces a constant that both can use. PR-URL: #11199 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
PR-URL: #11473 Ref: #11199 (comment) Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #11482 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
PR-URL: #11377 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
If any tests leave processes running after testing results are complete, fail the test run. PR-URL: #11269 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
I noticed that the link to http-parser is pointing to the joyent organization. There is a redirect to the nodejs organization but perhaps this should be updated anyway. PR-URL: #11477 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Interpretation of escape sequences with echo is not as consistent across platforms as printf, so use the latter instead. PR-URL: #11466 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #11454 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Also removes extraneous argument. PR-URL: #11413 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Formatting changes for upcoming linter update. PR-URL: #10561 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
We have been stalled on ESLint 3.8.0 for some time. Current ESLint is 3.13.0. We have been unable to upgrade because of more aggressive reporting on some rules, including indentation. ESLint configuration options and bugfixes are now such that we can reasonably upgrade. PR-URL: #10561 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
ESLint `indent` rule now has options that duplicate functionality in our custom `align-function-arguments` rule. Remove `align-function-arguments` custom rule. PR-URL: #10561 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
This adds an anchor for v6.10.0 in the LTS column. PR-URL: #11534 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
nodejs-github-bot
added
build
MylesBorins
force-pushed
the
v6.10.1-proposal
branch
from
5708840
to
80fe55d
Compare
2 tasks
MylesBorins
force-pushed
the
v6.10.1-proposal
branch
from
80fe55d
to
d6b6ed8
Compare
|
Left it too long, one more run ci: https://ci.nodejs.org/job/node-test-pull-request/6950/ edit: CI is green CITGM is good... two OSX failures pass locally. Similar failures on ubuntu 1604 for readable stream https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/665/nodes=ubuntu1604-64/testReport/ |
|
/cc @nodejs/streams to take a look into the 1604 issue... noticing same problem on this platform for both v4 and v6. |
|
@MylesBorins it's an issue on the vm, not sure how it was solved last time. the |
|
cc/ @nodejs/build |
### Notable changes
* **performance**: The performance of several APIs has been improved.
- `Buffer.compare()` is up to 35% faster on average. (Brian White) [#10927](https://github.com/nodejs/node/pull/10927)
- `buffer.toJSON()` is up to 2859% faster on average. (Brian White) [#10895](https://github.com/nodejs/node/pull/10895)
- `fs.*statSync()` functions are now up to 9.3% faster on average. (Brian White) [#11522](https://github.com/nodejs/node/pull/11522)
- `os.loadavg` is up to 151% faster. (Brian White) [#11516](https://github.com/nodejs/node/pull/11516)
- `process.memoryUsage()` is up to 34% faster. (Brian White) [#11497](https://github.com/nodejs/node/pull/11497)
- `querystring.unescape()` for `Buffer`s is 15% faster on average. (Brian White) [#10837](https://github.com/nodejs/node/pull/10837)
- `querystring.stringify()` is up to 7.8% faster on average. (Brian White) [#10852](https://github.com/nodejs/node/pull/10852)
- `querystring.parse()` is up to 21% faster on average. (Brian White) [#10874](https://github.com/nodejs/node/pull/10874)
* **IPC**: Batched writes have been enabled for process IPC on platforms that support Unix Domain Sockets. (Alexey Orlenko) [#10677](https://github.com/nodejs/node/pull/10677)
- Performance gains may be up to 40% for some workloads.
* **child_process**: `spawnSync` now returns a null `status` when child is terminated by a signal. (cjihrig) [#11288](https://github.com/nodejs/node/pull/11288)
- This fixes the behavior to act like `spawn()` does.
* **http**:
- Control characters are now always rejected when using `http.request()`. (Ben Noordhuis) [#8923](https://github.com/nodejs/node/pull/8923)
- Debug messages have been added for cases when headers contain invalid values. (Evan Lucas) [#9195](https://github.com/nodejs/node/pull/9195)
* **node**: Heap statistics now support values larger than 4GB. (Ben Noordhuis) [#10186](https://github.com/nodejs/node/pull/10186)
* **timers**: Timer callbacks now always maintain order when interacting with domain error handling. (John Barboza) [#10522](https://github.com/nodejs/node/pull/10522)Maybe we should just remove |
Notable changes
* performance: The performance of several APIs has been improved.
- `Buffer.compare()` is up to 35% faster on average. (Brian White)
#10927
- `buffer.toJSON()` is up to 2859% faster on average. (Brian White)
#10895
- `fs.*statSync()` functions are now up to 9.3% faster on average.
(Brian White) #11522
- `os.loadavg` is up to 151% faster. (Brian White)
#11516
- `process.memoryUsage()` is up to 34% faster. (Brian White)
#11497
- `querystring.unescape()` for `Buffer`s is 15% faster on average.
(Brian White) #10837
- `querystring.stringify()` is up to 7.8% faster on average.
(Brian White) #10852
- `querystring.parse()` is up to 21% faster on average. (Brian White)
#10874
* IPC:
- Batched writes have been enabled for process IPC on platforms that
support Unix Domain Sockets. (Alexey Orlenko)
#10677
- Performance gains may be up to 40% for some workloads.
* child_process:
- `spawnSync` now returns a null `status` when child is terminated by
a signal. (cjihrig) #11288
- This fixes the behavior to act like `spawn()` does.
* http:
- Control characters are now always rejected when using
`http.request()`. (Ben Noordhuis)
#8923
- Debug messages have been added for cases when headers contain
invalid values. (Evan Lucas)
#9195
* node:
- Heap statistics now support values larger than 4GB. (Ben Noordhuis)
#10186
* timers:
- Timer callbacks now always maintain order when interacting with
domain error handling. (John Barboza)
#10522
PR-URL: #11759
MylesBorins
force-pushed
the
v6.10.1-proposal
branch
from
d6b6ed8
to
e70d0b0
Compare
MylesBorins
added a commit
that referenced
this pull request
Mar 21, 2017
MylesBorins
added a commit
that referenced
this pull request
Mar 21, 2017
Notable changes
* performance: The performance of several APIs has been improved.
- `Buffer.compare()` is up to 35% faster on average. (Brian White)
#10927
- `buffer.toJSON()` is up to 2859% faster on average. (Brian White)
#10895
- `fs.*statSync()` functions are now up to 9.3% faster on average.
(Brian White) #11522
- `os.loadavg` is up to 151% faster. (Brian White)
#11516
- `process.memoryUsage()` is up to 34% faster. (Brian White)
#11497
- `querystring.unescape()` for `Buffer`s is 15% faster on average.
(Brian White) #10837
- `querystring.stringify()` is up to 7.8% faster on average.
(Brian White) #10852
- `querystring.parse()` is up to 21% faster on average. (Brian White)
#10874
* IPC:
- Batched writes have been enabled for process IPC on platforms that
support Unix Domain Sockets. (Alexey Orlenko)
#10677
- Performance gains may be up to 40% for some workloads.
* child_process:
- `spawnSync` now returns a null `status` when child is terminated by
a signal. (cjihrig) #11288
- This fixes the behavior to act like `spawn()` does.
* http:
- Control characters are now always rejected when using
`http.request()`. (Ben Noordhuis)
#8923
- Debug messages have been added for cases when headers contain
invalid values. (Evan Lucas)
#9195
* node:
- Heap statistics now support values larger than 4GB. (Ben Noordhuis)
#10186
* timers:
- Timer callbacks now always maintain order when interacting with
domain error handling. (John Barboza)
#10522
PR-URL: #11759
imyller
added a commit
to imyller/meta-nodejs
that referenced
this pull request
Apr 20, 2017
Notable changes
* performance: The performance of several APIs has been improved.
- `Buffer.compare()` is up to 35% faster on average. (Brian White)
nodejs/node#10927
- `buffer.toJSON()` is up to 2859% faster on average. (Brian White)
nodejs/node#10895
- `fs.*statSync()` functions are now up to 9.3% faster on average.
(Brian White) nodejs/node#11522
- `os.loadavg` is up to 151% faster. (Brian White)
nodejs/node#11516
- `process.memoryUsage()` is up to 34% faster. (Brian White)
nodejs/node#11497
- `querystring.unescape()` for `Buffer`s is 15% faster on average.
(Brian White) nodejs/node#10837
- `querystring.stringify()` is up to 7.8% faster on average.
(Brian White) nodejs/node#10852
- `querystring.parse()` is up to 21% faster on average. (Brian White)
nodejs/node#10874
* IPC:
- Batched writes have been enabled for process IPC on platforms that
support Unix Domain Sockets. (Alexey Orlenko)
nodejs/node#10677
- Performance gains may be up to 40% for some workloads.
* child_process:
- `spawnSync` now returns a null `status` when child is terminated by
a signal. (cjihrig) nodejs/node#11288
- This fixes the behavior to act like `spawn()` does.
* http:
- Control characters are now always rejected when using
`http.request()`. (Ben Noordhuis)
nodejs/node#8923
- Debug messages have been added for cases when headers contain
invalid values. (Evan Lucas)
nodejs/node#9195
* node:
- Heap statistics now support values larger than 4GB. (Ben Noordhuis)
nodejs/node#10186
* timers:
- Timer callbacks now always maintain order when interacting with
domain error handling. (John Barboza)
nodejs/node#10522
PR-URL: nodejs/node#11759
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
imyller
added a commit
to imyller/meta-nodejs
that referenced
this pull request
Apr 20, 2017
Notable changes
* performance: The performance of several APIs has been improved.
- `Buffer.compare()` is up to 35% faster on average. (Brian White)
nodejs/node#10927
- `buffer.toJSON()` is up to 2859% faster on average. (Brian White)
nodejs/node#10895
- `fs.*statSync()` functions are now up to 9.3% faster on average.
(Brian White) nodejs/node#11522
- `os.loadavg` is up to 151% faster. (Brian White)
nodejs/node#11516
- `process.memoryUsage()` is up to 34% faster. (Brian White)
nodejs/node#11497
- `querystring.unescape()` for `Buffer`s is 15% faster on average.
(Brian White) nodejs/node#10837
- `querystring.stringify()` is up to 7.8% faster on average.
(Brian White) nodejs/node#10852
- `querystring.parse()` is up to 21% faster on average. (Brian White)
nodejs/node#10874
* IPC:
- Batched writes have been enabled for process IPC on platforms that
support Unix Domain Sockets. (Alexey Orlenko)
nodejs/node#10677
- Performance gains may be up to 40% for some workloads.
* child_process:
- `spawnSync` now returns a null `status` when child is terminated by
a signal. (cjihrig) nodejs/node#11288
- This fixes the behavior to act like `spawn()` does.
* http:
- Control characters are now always rejected when using
`http.request()`. (Ben Noordhuis)
nodejs/node#8923
- Debug messages have been added for cases when headers contain
invalid values. (Evan Lucas)
nodejs/node#9195
* node:
- Heap statistics now support values larger than 4GB. (Ben Noordhuis)
nodejs/node#10186
* timers:
- Timer callbacks now always maintain order when interacting with
domain error handling. (John Barboza)
nodejs/node#10522
PR-URL: nodejs/node#11759
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2017-03-21, Version 6.10.1 'Boron' (LTS), @MylesBorins
This LTS release comes with 297 commits. This includes 124 which are test related,
79 which are doc related, 16 which are build / tool related and 4 commits which are updates to dependencies.
Notable Changes
Coming Soon
Commits
fb75bed078] - assert: unlock the assert API (Rich Trott) #1130432b264c33b] - assert: remove unneeded condition (Rich Trott) #11314a0c705ef79] - assert: apply minor refactoring (Rich Trott) #115117ecfe4971a] - assert: update comments (Kai Cataldo) #105794d6fa8d040] - benchmark: add more thorough timers benchmarks (Jeremiah Senkpiel) #10925406e623b13] - benchmark: add benchmark for object properties (Michaël Zasso) #109497ee04c6015] - benchmark: don't lint autogenerated modules (Brian White) #10756d22d7cce7c] - benchmark: move punycode benchmark out of net (Brian White) #104466b361611c3] - benchmark: move setImmediate benchmarks to timers (Joshua Colvin) #11010a469ce5826] - benchmark: add assert.deep[Strict]Equal benchmarks (Joyee Cheung) #11092eca1e80722] - benchmark: add dgram bind(+/- params) benchmark (Vse Mozhet Byt) #1131306c339dcce] - benchmark: improve readability of net benchmarks (Brian White) #10446b4cf8c4036] - benchmark,lib,test: adjust for linting (Rich Trott) #10561e397e6f94a] - buffer: improve compare() performance (Brian White) #109272b52859535] - buffer: fix comments in bidirectionalIndexOf (dcposch@dcpos.ch) #10162f7879d98f8] - buffer: improve toJSON() performance (Brian White) #10895f83d035c50] - buffer: convert offset & length to int properly (Sakthipriyan Vairamani (thefourtheye)) #11176cda593774f] - build: sort sources alphabetically (Daniel Bevenius) #108922d31fd8bf7] - build: move source files from headers section (Daniel Bevenius) #10850b7c5295437] - build: don't squash signal handlers with --shared (Stewart X Addison) #105396772b1d81c] - build: disable C4267 conversion compiler warning (Ben Noordhuis) #1120593416e9b7a] - build: fix newlines in addon build output (Brian White) #114662d5cb3b870] - build: fail on CI if leftover processes (Rich Trott) #11269edcca78f10] - build: add rule to clean addon tests build (Joyee Cheung) #115190200a5a74e] - build: fix node_g target (Daniel Bevenius) #10153f44c0a5d7a] - build: Don't regenerate node symlink (sxa555) #9827947d07bd87] - child_process: exit spawnSync with null on signal (cjihrig) #112884179c7050f] - child_process: move anonymous class to top level (Jackson Tian) #11147818cef848e] - child_process: remove empty if condition (cjihrig) #11427c371fdcf34] - child_process: refactor internal/child_process.js (Arseniy Maximov) #11366b662c117cb] - crypto: return the retval of HMAC_Update (Travis Meisenheimer) #1089144510197dd] - crypto: freelist_max_len is gone in OpenSSL 1.1.0 (Adam Langley) #1085934614af53b] - crypto: add cert check issued by StartCom/WoSign (Shigeki Ohtsu) #9469b4b3bb4c5d] - crypto: Remove expired certs from CNNIC whitelist (Shigeki Ohtsu) #94691f44922e34] - crypto: use CHECK_NE instead of ABORT or abort (Sam Roberts) #10413ccb6045f2d] - crypto,tls: fix mutability of return values (Rich Trott) #107953ab070d4e1] - deps: backport dfb8d33 from V8 upstream (Michaël Zasso) #114833fc6a2247f] - deps: cherry-pick a814b8a from upstream V8 (ishell@chromium.org) #10733254cb1cb77] - deps: back-port 73ee7943 from v8 upstream (Ben Noordhuis) #9293e774de1685] - deps: back-port 306c412c from v8 upstream (Ben Noordhuis) #9293e5d1e273d7] - dgram: fix possibly deoptimizing use of arguments (Vse Mozhet Byt) #11242c7257e716f] - dgram: remove this aliases (cjihrig) #11243227cc1e810] - doc: restrict the ES.Next features usage in tests (DavidCai) #1145223246768fb] - doc: add missing entry in v6 changelog table (Luigi Pinca) #11534ff9a86a73e] - doc: remove Chris Dickinson from active releasers (Ben Noordhuis) #11011313d1a3009] - doc: for style, remove "isn't" contraction (Sam Roberts) #10981ab7587ed6c] - doc: update http.md for consistency and clarity (Lance Ball) #1071521a94ab78c] - doc: clarify Buffer.indexOf/lastIndexOf edge cases (dcposch@dcpos.ch) #101628c487de736] - doc: document argument variant in the repl.md (Vse Mozhet Byt) #10221130710476b] - doc: DEFAULT_ECDH_CURVE was added in 0.11.13 (Sam Roberts) #109835118e05b15] - doc: HTTP response getHeader doc fix (Faiz Halde) #10817243652abbe] - doc: remove duplicate properties bullet in readme (Javis Sullivan) #10741fa8a394e51] - doc: specify sorted requires in tests (Sam Roberts) #107161660311056] - doc: fix typo in http.md (Peter Mescalchin) #109758936814a70] - doc: add who to CC list for dgram (cjihrig) #11035b934058128] - doc: correct and complete dgram's Socket.bind docs (Alex Jordan) #11025faa55fbe09] - doc: edit CONTRIBUTING.md for clarity (Rich Trott) #11045c26258e1fd] - doc: fix confusing example in dns.md (Vse Mozhet Byt) #110228bf7f9f202] - doc: add personal pronouns option (Rich Trott) #110897c22a52a74] - doc: clarify msg when doc/api/cli.md not updated (Stewart X Addison) #10872d404d8b673] - doc: edit stability text for clarity and style (Rich Trott) #1111238938e1ba9] - doc: remove assertions about assert (Rich Trott) #1111389d30908f2] - doc: fix "initial delay" link in http.md (Timo Tijhof) #11108c0072f8d71] - doc: typographical fixes in COLLABORATOR_GUIDE.md (Anna Henningsen) #11163207142d050] - doc: add not-an-aardvark as ESLint contact (Rich Trott) #111693746eee19d] - doc: improve testing guide (Joyee Cheung) #111506cadc7160f] - doc: remove extraneous paragraph from assert doc (Rich Trott) #11174d5d8a8d7b5] - doc: fix typo in dgram doc (Rich Trott) #1118659a1d00906] - doc: add and fix System Error properties (Daiki Arai) #1098672adba4317] - doc: add links between cork() and uncork() (Matteo Collina) #112221cd526c253] - doc: clarify the behavior of Buffer.byteLength (Nikolai Vavilov) #11238b1bda165ce] - doc: edit maxBuffer/Unicode paragraph for clarity (Rich Trott) #112281150af00f7] - doc: improve consistency in documentation titles (Vse Mozhet Byt) #11230ade39cdf9c] - doc: drop "and io.js" from release section (Ben Noordhuis) #11054c79d9f95d1] - doc: update email and add personal pronoun (JungMinu) #113187df4ee8d49] - doc: update link to V8 Embedder's guide (Franziska Hinkelmann) #113368468d823a8] - doc: update code examples in domain.md (Vse Mozhet Byt) #1111010a497cdcb] - doc: describe when stdout/err is sync (Sam Roberts) #1088453d5002ef9] - doc: dns examples implied string args were arrays (Sam Roberts) #1135042304de4f7] - doc: change STYLE-GUIDE to STYLE_GUIDE (Dean Coakley) #1146013a9ba9523] - doc: add STYLE_GUIDE (moved from nodejs/docs) (Gibson Fahnestock) #113210164d9263e] - doc: improve test/README.md (Joyee Cheung) #11237e0868aa529] - doc: add comment for net.Server's error event (QianJin2013) #111369a684a1511] - doc: note message event listeners ref IPC channels (Diego Rodríguez Baquero) #11494bfa3989584] - doc: argument types for assert methods (Amelia Clarke) #11548fc41a1d34d] - doc: document clientRequest.aborted (Zach Bjornson) #11544ff77425eba] - doc: link to readable and writeable stream section (Sebastian Van Sande) #115174850b503dd] - doc: update TheAlphaNerd to MylesBorins (Myles Borins) #10586d04de226a1] - doc: update examples in api/crypto.md (Vse Mozhet Byt) #10909a045af3b95] - doc: update AUTHORS list to fix name (Noah Rose Ledesma) #10945d266759b99] - doc: add TimothyGu to collaborators (Timothy Gu) #1095442a5989b39] - doc: mention moderation repo in onboarding doc (Anna Henningsen) #10869cdc981f6e1] - doc: add edsadr to collaborators (Adrian Estrada) #10883787d4ec197] - doc: clarifying variables in fs.write() (Jessica Quynh Tran) #9792f48c86ce48] - doc: add links for zlib convenience methods (Anna Henningsen) #108291dbb366611] - doc: add missingadded:tag forzlib.constants(Anna Henningsen) #10826867b4d87dc] - doc: fix broken internal link in process.md (Anna Henningsen) #108286d726c07aa] - doc: update writable.write return value (Nathan Phillip Brink) #105821975f82168] - doc: edit writing-tests.md (Rich Trott) #10585494ee5163f] - doc: fix misleading language in vm docs (Alexey Orlenko) #107088e807f6552] - doc: mention cc-ing nodejs/url team for reviews (Anna Henningsen) #10652f9bd4a5645] - doc: sort require statements in tests (Sam Roberts) #10616032d73841d] - doc: handle backpressure when write() return false (Matteo Collina) #10631af991c7a98] - doc: add test naming information to guide (Rich Trott) #10584b5fd61d77a] - doc: fix missing negation in stream.md (Johannes Rieken) #107127e5a59e6fc] - doc: "s/git apply/git am -3" in V8 guide (Myles Borins) #10665789bafd693] - doc: update LTS info for current releases (Evan Lucas) #10720fef978584a] - doc: update BUILDING.md (Lukasz Gasior) #10669f2ddc72b62] - doc: document use of Refs: for references (Gibson Fahnestock) #106700a1d15fba6] - doc: clarify information about ABI version (Rich Trott) #1041922f3813b3e] - doc: clarify the statement in vm.createContext() (AnnaMag) #1051938d63e49eb] - doc: improve rinfo object documentation (Matt Crummey) #10050998fd1e7e1] - doc: add tls.DEFAULT_ECDH_CURVE (Sam Roberts) #102644995a819e0] - doc: fix a wrong note in the buffer.md (Vse Mozhet Byt) #97956d3c2d6212] - doc: fix examples in buffer.md to avoid confusion (Vse Mozhet Byt) #9795020c90eb2d] - doc: remove a wrong remark in the buffer.md (Vse Mozhet Byt) #97958af811f90e] - doc: fix copy-paste artifacts in the buffer.md (Vse Mozhet Byt) #9795a2b40ad6a4] - doc: fix wrong function arguments in the buffer.md (Vse Mozhet Byt) #9795e94abaec1c] - doc: fix a syntax error in the buffer.md (Vse Mozhet Byt) #9795b36c315423] - doc: var => const/let in the buffer.md (Vse Mozhet Byt) #9795b503824b81] - doc,test: args tobuffer.copycan be Uint8Arrays (Anna Henningsen) #11486c8d2ca7a78] - fs: improve performance for sync stat() functions (Brian White) #11522b4dc7a778f] - http: make request.abort() destroy the socket (Luigi Pinca) #10818d777da27bc] - http: reject control characters in http.request() (Ben Noordhuis) #8923bad0d9367e] - http: add debug message for invalid header value (Evan Lucas) #9195bde1a7e09e] - lib: remove unnecessary parameter for assertCrypto() (Jackson Tian) #10834a2aa2f7de4] - lib: refactor bootstrap_node.js regular expression (Rich Trott) #10749797d9ee924] - lib: refactor crypto cipher/hash/curve getters (Rich Trott) #1068269327f5e72] - lib: rename kMaxCallbacksUntilQueueIsShortened (JungMinu) #11473a6b2dfa43c] - lib: add constant kMaxCallbacksUntilQueueIsShortened (Daniel Bevenius) #11199a3ad63b9b3] - lib,src: support values > 4GB in heap statistics (Ben Noordhuis) #101868b5dd35ae8] - meta: add explicit deprecation and semver-major policy (James M Snell) #79644df850ba59] - meta: remove Chris Dickinson from CTC (Chris Dickinson) #112678863360a21] - meta: adding Italo A. Casas PGP Fingerprint (Italo A. Casas) #112028287d03adf] - meta: decharter the http working group (James M Snell) #10604742ec6213f] - net: prefer === to == (Arseniy Maximov) #115135bfa43d8f0] - os: improve loadavg() performance (Brian White) #11516b7088a9355] - process: improve memoryUsage() performance (Brian White) #1149702e5f5c57e] - process: fix typo in comments (levsthings) #11503db45bf850a] - querystring: improve unescapeBuffer performance (Brian White) #1083732cdbca2dc] - querystring: improve stringify() performance (Brian White) #1085223f3f20963] - querystring: improve parse() performance (Brian White) #10874dc88b6572d] - readline: refactor construct Interface (Jackson Tian) #4740f7c6ad2df9] - readline: update 6 comparions to strict (Umair Ishaq) #11078b5a0d46c55] - src: add NODE_NO_WARNINGS to --help output (cjihrig) #10918566e2fea48] - src: remove unnecessary req_wrap_obj (Daniel Bevenius) #10942c7436df889] - src: add a missing space in node_os.cc (Alexey Orlenko) #109314358c6096c] - src: enable writev for pipe handles on Unix (Alexey Orlenko) #1067728102edbc8] - src: unconsume stream fix in internal http impl (Roee Kasher) #11015587857e301] - src: fix delete operator on vm context (Franziska Hinkelmann) #11266b7cbb8002c] - src: support UTF-8 in compiled-in JS source files (Ben Noordhuis) #11129ce01372b68] - src: remove unused typedef (Ben Noordhuis) #113221dddfeccb2] - src: remove usage of deprecated debug API (Yang Guo) #114377f273c6f6e] - src: update http-parser link (Daniel Bevenius) #11477214b514efe] - src: use ABORT() macro instead of abort() (Evan Lucas) #9613412f380903] - stream: move legacy to lib/internal dir (yorkie) #8197336f1bd842] - test: increase setMulticastLoopback() coverage (cjihrig) #11277b29165f249] - test: increase dgram ref()/unref() coverage (cjihrig) #1124022d4ed2484] - test: add an exception test to http-write-head (Yuta Hiroto) #110349edd342e81] - test: add known_issues test for Object.defineProperty on the global object does not handle 'writable' properly in vm context #10223 (AnnaMag) #11024646f82520c] - test: guarantee test runs in test-readline-keys (Rich Trott) #11023d8eed12d31] - test: check error message in test-http-outgoing-proto (Alex Ling) #10943174bef182a] - test: increase coverage for stream's duplex (abouthiroppy) #109638ff15a262d] - test: allow for slow hosts in spawnSync() test (Rich Trott) #1099862f6749cd6] - test: expand test coverage of fs.js (Vinícius do Carmo) #109475cea2239d8] - test: expand test coverage of events.js (Vinícius do Carmo) #10947a1751864e2] - test: check noAssert option in buf.write*() (larissayvette) #107900b5f2b45f9] - test: expand test coverage of fs.js (Vinícius do Carmo) #10972d9362efb6c] - test: enhance test-timers (Rich Trott) #10960b9615b3abc] - test: increase coverage for exec() functions (cjihrig) #10919b45280671a] - test: add process.assert's test (abouthiroppy) #109116584ea0715] - test: update Buffer.lastIndexOf (dcposch@dcpos.ch) #101620c60540014] - test: improve code in test-crypto-verify (Adrian Estrada) #108452a52a68a96] - test: add dgram.Socket.prototype.bind's test (abouthiroppy) #108942494d8ac68] - test: update V8 flag in test (Franziska Hinkelmann) #109179ac22cdcaf] - test: increase coverage of string-decoder (abouthiroppy) #10863d766f5e0ad] - test: improving coverage of dns-lookup (abouthiroppy) #108448f984c3a8a] - test: refactor test-fs-read-zero-length.js (abouthiroppy) #10729c0e24f9029] - test: improving coverage for dgram (abouthiroppy) #10783c91d873115] - test: improve code in test-console-instance (Adrian Estrada) #10813a434f451d9] - test: improve code in test-domain-multi (Adrian Estrada) #10798b01db3a73f] - test: improve test-stream2-large-read-stall (stefan judis) #1072576f0556c4a] - test: improve code in test-http-host-headers (Adrian Estrada) #10830c740cb6667] - test: add test case to test-http-response-statuscode.js (abouthiroppy) #10808872354563c] - test: refactor cluster-preload.js (abouthiroppy) #1070104dc1cdfcb] - test: improve test-fs-write-file-sync (Adrian Estrada) #106240d25d056a4] - test: test hmac binding robustness (Sam Roberts) #1092399a234c97e] - test: refactor the code in test-fs-watch.js (sivaprasanna) #10357c13f01c94d] - test: reduce unmanaged parallelism in domain test (Joyee Cheung) #10329ed76b4a8e9] - test: add dgram.Socket.prototype.sendto's test (abouthiroppy) #109015365501a2f] - test: add regression test for V8 parse error (Michaël Zasso) #11483b5fb9f4098] - test: increase timeout in break-on-uncaught (Sakthipriyan Vairamani (thefourtheye)) #10822443dd508d2] - test: fix process.title expectation (Sakthipriyan Vairamani (thefourtheye)) #10597ae338daf06] - test: refactor test-debugger-remote (Sakthipriyan Vairamani (thefourtheye)) #1045534e0bc6d16] - test: fix and improve debugger-client test (Sakthipriyan Vairamani (thefourtheye)) #10371da874590a6] - test: improve test-assert (richnologies) #10916a15ecd269d] - test: increase coverage for punycode's decode (abouthiroppy) #1094098e32db207] - test: check fd 0,1,2 are used, not access mode (John Barboza) #10339e59697c695] - test: fix flaky test-regress-net: make Server.prototype.unref() persistent #897 (Rich Trott) #10903a08c7f6d87] - test: don't connect to :: (use localhost instead) (Gibson Fahnestock) #10854ca53866333] - test: add message verification on assert.throws (Travis Meisenheimer) #1089038b123c918] - test: refactor test-repl-tab-complete (Rich Trott) #1087968fc4d3a1c] - test: simplify array initialization (Rich Trott) #10860a26d752e77] - test: add http-common's test (abouthiroppy) #1083280e2ff9bff] - test: tests for _readableStream.awaitDrain (Mark) #8914e4e9f675d2] - test: improve the code in test-process-cpuUsage (Adrian Estrada) #1071473c0c46cf2] - test: increase test-crypto.js strictness (Rich Trott) #10784e316fafbd4] - test: delete duplicate test of noAssert in readUInt* (larissayvette) #10791896fb63173] - test: add http_incoming's matchKnownFields test (abouthiroppy) #10811c086bdc2de] - test: check error msg test-writeint.js (Irene Li) #107552eb0c25aa1] - test: no unused args test-fs-watch-file.js (istinson) #107582f026f6668] - test: improve tests in pummel/test-exec (Chase Starr) #1075793877c87cc] - test: fix temp-dir option in tools/test.py (Gibson Fahnestock) #107230f3677dd5d] - test: use realpath for NODE_TEST_DIR in common.js (Gibson Fahnestock) #107235d0cc617bb] - test: move resource intensive test to sequential (Rich Trott) #10744cd4bb067ad] - test: add test for noAssert option in buf.read*() (larissayvette) #107135b55689b2c] - test: refactor test-crypto-padding-aes256 (adelmann) #10622119e512db3] - test: refactor the code of test-keep-alive.js (sivaprasanna) #10684ef3d889ee7] - test: validate 'expected' argument to mustCall() (Nathan Friedly) #1069221704a3b6b] - test: fix misplaced ) in http response statuscode test (Nathan Friedly) #106928565a06b09] - test: refactor test-doctool-html.js (abouthiroppy) #10696168f3e4bf8] - test: improve the code in test-process-hrtime (Adrian Estrada) #106679acc86f578] - test: refactor test-watch-file.js (sivaprasanna) #1067986e39367d6] - test: improve zlib-from-gzip-with-trailing-garbage (Michael Lefkowitz) #106743135455cd9] - test: refactor the code in test-child-process-spawn-loop.js (sivaprasanna) #10605f43a8765a2] - test: allow testing uid and gid separately (cjihrig) #106472f1d231c0d] - test: improve test-http-chunked-304 (Adrian Estrada) #10462ec8a9962ce] - test: improve test-fs-readfile-zero-byte-liar (Adrian Estrada) #1057012746af524] - test: refactor test-fs-utimes (Junshu Okamoto) #9290e81b1cc1ae] - test: provide duration/interval to timers (Rich Trott) #947217a63e15e6] - test: improve test-event-emitter-modify-in-emit (Adrian Estrada) #1060050ee4e6dad] - test: require handler to be run in sigwinch test (Rich Trott) #110688cce29587c] - test: add 2nd argument to throws in test-assert (Marlena Compton) #11061b14d7b3aa1] - test: improve error messages in test-npm-install (Gonen Dukas) #1102787488ba2ff] - test: add path.join's test (Yuta Hiroto) #11063232664a10d] - test: fix timing sensitivity in debugger test (Ali Ijaz Sheikh) #11008c16160418b] - test: improve coverage on removeListeners functions (matsuda-koushi) #11140898276b1b4] - test: simplify output handling in repl tests (Rich Trott) #111243248cdb2e6] - test: improve crypto.setEngine coverage to check for errors (Sebastian Van Sande) #1114328111f9eb2] - test: increase specificity in dgram test (Rich Trott) #11187c5e8ccab63] - test: remove obsolete comment from dgram test (ALJCepeda) #86897aebc6907c] - test: improve checks in test-path-parse-format (cjihrig) #11223baec432c93] - test: add coverage for string array dgram send() (cjihrig) #112476694c26420] - test: adapt test-debugger-pid to localized Windows (Vse Mozhet Byt) #112702db4c3c453] - test: add vm module edge cases (Franziska Hinkelmann) #11265759604912a] - test: refactor test-dgram-setBroadcast.js (cjihrig) #112523185fa1249] - test: querystring.escape with multibyte characters (Daijiro Wachi) #11251460a3e1f7a] - test: improve test-assert.js (jobala) #111931adfca4b5e] - test: refactor test-repl-sigint (Rich Trott) #11309c539325d89] - test: improve punycode test coverage (Sebastian Van Sande) #111448db3c770be] - test: refactor test-repl-sigint-nested-eval (Rich Trott) #11303874ef9d312] - test: add coverage for dgram _createSocketHandle() (cjihrig) #1129192f6919532] - test: improve crypto coverage (Akito Ito) #11280d9deb1fb62] - test: improve message in net-connect-local-error (Rich Trott) #113936677c113aa] - test: refactor test-dgram-membership (Rich Trott) #11388e7b7d7279c] - test: cases to querystring related to empty string (Daijiro Wachi) #113295a92fc25a1] - test: consolidate buffer.read() in a file (larissayvette) #11297607158ab6e] - test: improve crypto coverage (樋口 彰) #1127927f302d94f] - test: remove unused args and comparison fix (Alexander) #113968da156d68f] - test: add coverage for utf8CheckIncomplete() (xiaoyu) #114190ddad76813] - test: fix over-dependence on native promise impl (Ali Ijaz Sheikh) #1143734444580f6] - test: add test cases for path (Yuta Hiroto) #114534bcf1a0387] - test: refactor test-http-response-splitting (Arseniy Maximov) #114297836807178] - test: add error checking in callback (Rich Trott) #1144613b7856444] - test: improve coverage in test-crypto.dh (Eric Christie) #11253b2f7e7a5ad] - test: add regex check to test-module-loading (Tarang Hirani) #114136bf936644e] - test: increase coverage of vm (DavidCai) #113776202f14583] - test: throw check in test-zlib-write-after-close (Jason Wilson) #11482f8884dd1b5] - test: add cases for unescape & unescapeBuffer (Daijiro Wachi) #1132605909d045b] - test: fix flaky test-vm-timeout-rethrow (Kunal Pathak) #115306e5f6e3c02] - test: favor assertions over console logging (Rich Trott) #115472c4aa39021] - test: mark test-tty-wrap as flaky for AIX (Michael Dawson) #10618cb03e74037] - test: improve test-fs-null-bytes (Adrian Estrada) #1052169b55f35f7] - test: refactor test-https-truncate (Rich Trott) #10225ada7166dfd] - test: simplify test-http-client-unescaped-path (Rod Vagg) #96491b85989fb2] - test: move long-running test to sequential (Rich Trott) #1117687760cc346] - test: add new.target add-on regression test (Ben Noordhuis) #968973283060ad] - test,repl: add coverage for repl .clear+useGlobal (Rich Trott) #107774a87aee532] - test,util: remove lint workarounds (Rich Trott) #107853e9ce770f7] - test-console: streamline arrow fn and refine regex (John Maguire) #11039b90a141cc7] - timer: remove duplicated word in comment (asafdav2) #11323d71ebb90ec] - timer,domain: maintain order of timer callbacks (John Barboza) #105222a168917cb] - tls: do not crash on STARTTLS when OCSP requested (Fedor Indutny) #10706f33684ac5f] - tools: remove custom align-function-arguments rule (Rich Trott) #10561fb2f449acc] - tools: update ESLint to current version (Rich Trott) #1056183a3aef873] - tools: rename eslintrc to an undeprecated format (Sakthipriyan Vairamani) #7699e4f7f5c630] - tools: add lint rule to enforce timer arguments (Rich Trott) #9472a13bb54466] - tools: add compile_commands.json gyp generator (Ben Noordhuis) #7986b38d8d6e06] - tools: suggest python2 command in configure (Roman Reiss) #11375291346ea51] - tools,doc: add Google Analytics tracking. (Phillip Johnsen) #66011ed47d3f33] - tty: avoid oob warning in TTYWrap::GetWindowSize() (Dmitry Tsvettsikh) #114549e6fcbb34c] - url: fix surrogate handling in encodeAuth() (Timothy Gu) #1138753213004eb] - util: improve readability of normalizeEncoding (Joyee Cheung) #10439e54b433c8d] - util: use ES2015+ Object.is to check negative zero (Shinnosuke Watanabe) #113322e15d48447] - v8: drop v8::FunctionCallbackInfo<T>::NewTarget() (Ben Noordhuis) #9293fd1ffe4f5a] - v8: fix --always-opt bug (Ben Noordhuis) #9293a55af77fc5] - vm: refactor vm module (James M Snell) #11392