Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: fix accidental filemode change #10549

Closed
wants to merge 1 commit into from
Closed

url: fix accidental filemode change #10549

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Dec 30, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

url

Description

Commit 2213f36 included an accidental file mode change. This reverts it.

/cc @mscdex

@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x url Issues and PRs related to the legacy built-in url module. labels Dec 30, 2016
@mscdex
Copy link
Contributor

mscdex commented Dec 30, 2016

LGTM

Trott
Trott approved these changes Dec 31, 2016
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jasnell added a commit that referenced this pull request Jan 3, 2017
@jasnell
url: fix accidental filemode change
ac90d29 
PR-URL: #10549
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@jasnell
Copy link
Member Author

jasnell commented Jan 3, 2017

Landed in ac90d29

@jasnell jasnell closed this Jan 3, 2017
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
@jasnell @evanlucas
url: fix accidental filemode change
659d522 
PR-URL: #10549
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@evanlucas evanlucas mentioned this pull request Jan 4, 2017
Merged
@joyeecheung joyeecheung added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
url Issues and PRs related to the legacy built-in url module. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
No open projects
WHATWG URL implementation
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jasnell @mscdex @Trott @lpinca @targos @cjihrig @joyeecheung @nodejs-github-bot