url: fix accidental filemode change #10549

Closed
wants to merge 1 commit into
from

Projects

Done in WHATWG URL implementation

8 participants

@jasnell
Member
jasnell commented Dec 30, 2016
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

url

Description

Commit 2213f36 included an accidental file mode change. This reverts it.

/cc @mscdex

@targos
targos approved these changes Dec 30, 2016 View changes
@mscdex
Contributor
mscdex commented Dec 30, 2016

LGTM

@Trott
Trott approved these changes Dec 31, 2016 View changes

LGTM

@lpinca
lpinca approved these changes Dec 31, 2016 View changes
@jasnell jasnell added a commit that referenced this pull request Jan 3, 2017
@jasnell jasnell url: fix accidental filemode change
PR-URL: #10549
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
ac90d29
@jasnell
Member
jasnell commented Jan 3, 2017

Landed in ac90d29

@jasnell jasnell closed this Jan 3, 2017
@evanlucas evanlucas added a commit that referenced this pull request Jan 4, 2017
@jasnell @evanlucas jasnell + evanlucas url: fix accidental filemode change
PR-URL: #10549
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
659d522
@evanlucas evanlucas referenced this pull request Jan 4, 2017
Merged

v7.4.0 release proposal #10589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment