test: refactor test-crypto-padding-aes256 #10622
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Jan 5, 2017
|
Nit: typo in commit message and PR title: eas256 -> aes256 |
radelmann
changed the title
- replace var with const/let - replace assert.equal() with assert.strictEqual()
radelmann
force-pushed
the
test-crypto-padding-eas256.js
branch
from
e5f1d6e
to
2c08cdf
Compare
lpinca
approved these changes
Jan 5, 2017
|
bump |
jasnell
pushed a commit
that referenced
this pull request
Jan 10, 2017
* replace var with const/let * replace assert.equal() with assert.strictEqual() PR-URL: #10622 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in 596d86f |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
* replace var with const/let * replace assert.equal() with assert.strictEqual() PR-URL: nodejs#10622 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 23, 2017
* replace var with const/let * replace assert.equal() with assert.strictEqual() PR-URL: nodejs#10622 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 25, 2017
* replace var with const/let * replace assert.equal() with assert.strictEqual() PR-URL: nodejs#10622 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 27, 2017
* replace var with const/let * replace assert.equal() with assert.strictEqual() PR-URL: nodejs#10622 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 8, 2017
* replace var with const/let * replace assert.equal() with assert.strictEqual() PR-URL: #10622 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
* replace var with const/let * replace assert.equal() with assert.strictEqual() PR-URL: #10622 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This was referenced Nov 28, 2023
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
This was referenced Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
varwithconst/letassert.equal()withassert.strictEqual()Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test