Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing negation #10712

Closed
wants to merge 1 commit into from
Closed

Fix missing negation #10712

wants to merge 1 commit into from

Conversation

jrieken
Copy link
Contributor

@jrieken jrieken commented Jan 9, 2017 •
edited
Loading

This will fix #10710 by changing ..can result in expected to ..can result in unexpected

@jrieken
Fix missing negation
14ad012 
This will fix nodejs#10710 by changing `..can result in expected` to `..can result in unexpected`
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. lts-watch-v6.x labels Jan 9, 2017
@jasnell
Copy link
Member

jasnell commented Jan 10, 2017

This one is small enough that it does not need to wait the full 48 hours

jasnell pushed a commit that referenced this pull request Jan 10, 2017
@jrieken @jasnell
doc: fix missing negation in stream.md
4e8eb62 
Changing `..can result in expected` to `..can result in unexpected`

Fixes: #10710
PR-URL: #10712
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jan 10, 2017

Landed in 4e8eb62.
@jrieken ... thank you very much. Note that I edited the commit log message to conform to our contribution guidelines

@jasnell jasnell closed this Jan 10, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@jrieken @italoacasas
doc: fix missing negation in stream.md
305c650 
Changing `..can result in expected` to `..can result in unexpected`

Fixes: nodejs#10710
PR-URL: nodejs#10712
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 23, 2017
@jrieken @italoacasas
doc: fix missing negation in stream.md
a09cb27 
Changing `..can result in expected` to `..can result in unexpected`

Fixes: nodejs#10710
PR-URL: nodejs#10712
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 24, 2017
@jrieken @italoacasas
doc: fix missing negation in stream.md
47d7719 
Changing `..can result in expected` to `..can result in unexpected`

Fixes: nodejs#10710
PR-URL: nodejs#10712
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
@jrieken @italoacasas
doc: fix missing negation in stream.md
b73e98b 
Changing `..can result in expected` to `..can result in unexpected`

Fixes: nodejs#10710
PR-URL: nodejs#10712
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 7, 2017
@jrieken @MylesBorins
doc: fix missing negation in stream.md
0c5e02f 
Changing `..can result in expected` to `..can result in unexpected`

Fixes: #10710
PR-URL: #10712
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@jrieken @MylesBorins
doc: fix missing negation in stream.md
b5fd61d 
Changing `..can result in expected` to `..can result in unexpected`

Fixes: #10710
PR-URL: #10712
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc: missing negation in streams doc
6 participants
@jrieken @jasnell @lpinca @cjihrig @MylesBorins @nodejs-github-bot