Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test case to test-http-response-statuscode.js #10808

Closed
wants to merge 1 commit into from
Closed

test: add test case to test-http-response-statuscode.js #10808

wants to merge 1 commit into from

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Jan 14, 2017

Change regular expression of error message.
Add test case(res.writeHead()).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@hiroppy
test: add test case to test-http-response-statuscode.js
eb9ca7f 
Change regular expression of error message.
Add test case(`res.writeHead()`).
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. dont-land-on-v7.x labels Jan 14, 2017
@mscdex mscdex added http Issues or PRs related to the http subsystem. and removed dont-land-on-v7.x labels Jan 14, 2017
@mscdex
Copy link
Contributor

mscdex commented Jan 14, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/5862/

@hiroppy
Copy link
Member Author

hiroppy commented Jan 15, 2017 

Finished Build : #5922 of Job : node-test-binary-windows with status : FAILURE

hmm... I don't understand the cause.

@gibfahn
Copy link
Member

gibfahn commented Jan 15, 2017 •
edited
Loading

@abouthiroppy looks like a machine went offline (or a network problem) during the build. The test you changed passed, so almost certainly unrelated.

CI 2: https://ci.nodejs.org/job/node-test-commit/7248/

EDIT: CI 2 was green

Failure:

https://ci.nodejs.org/job/node-test-binary-windows/5922/RUN_SUBSET=1,VS_VERSION=vs2015,label=win2008r2/console

ok 231 parallel/test-stream-pipe-await-drain-manual-resume
  ---
  duration_ms: 0.250
  ...
FATAL: command execution failed
hudson.remoting.ChannelClosedException: channel is already closed
	...
Caused by: java.io.IOException: Connection aborted: org.jenkinsci.remoting.nio.NioChannelHub$MonoNioTransport@17c7fdc0[name=Channel to /104.239.231.190]
	...
Caused by: java.io.IOException: Connection timed out
	...
	... 6 more

@hiroppy
Copy link
Member Author

hiroppy commented Jan 15, 2017

@gibfahn Ah, I see. Thanks for running CI again.

cjihrig
cjihrig approved these changes Jan 15, 2017
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jasnell pushed a commit that referenced this pull request Jan 16, 2017
@hiroppy @jasnell
test: add test case to test-http-response-statuscode.js
e5eae97 
Change regular expression of error message.
Add test case(`res.writeHead()`).

PR-URL: #10808
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jan 16, 2017

Landed in e5eae97

@jasnell jasnell closed this Jan 16, 2017
@hiroppy hiroppy deleted the feature/improve-test-http-response-statuscode branch January 17, 2017 13:50
@hiroppy hiroppy mentioned this pull request Jan 17, 2017
Closed
3 tasks
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@hiroppy @italoacasas
test: add test case to test-http-response-statuscode.js
101aa47 
Change regular expression of error message.
Add test case(`res.writeHead()`).

PR-URL: nodejs#10808
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 23, 2017
@hiroppy @italoacasas
test: add test case to test-http-response-statuscode.js
e4b58a5 
Change regular expression of error message.
Add test case(`res.writeHead()`).

PR-URL: nodejs#10808
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 25, 2017
Closed
targos pushed a commit that referenced this pull request Jan 28, 2017
@hiroppy @targos
test: add test case to test-http-response-statuscode.js
89908ea 
Change regular expression of error message.
Add test case(`res.writeHead()`).

PR-URL: #10808
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@hiroppy @italoacasas
test: add test case to test-http-response-statuscode.js
66c57a2 
Change regular expression of error message.
Add test case(`res.writeHead()`).

PR-URL: nodejs#10808
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@hiroppy @italoacasas
test: add test case to test-http-response-statuscode.js
b57ff52 
Change regular expression of error message.
Add test case(`res.writeHead()`).

PR-URL: nodejs#10808
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 8, 2017
@hiroppy @jasnell
test: add test case to test-http-response-statuscode.js
1bbb611 
Change regular expression of error message.
Add test case(`res.writeHead()`).

PR-URL: #10808
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell
Copy link
Member

jasnell commented Mar 8, 2017

Landed in v6. A backport PR would be required for this to land in v4

MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@hiroppy @MylesBorins
test: add test case to test-http-response-statuscode.js
c740cb6 
Change regular expression of error message.
Add test case(`res.writeHead()`).

PR-URL: #10808
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
@adamlaska adamlaska mentioned this pull request Nov 25, 2023
Open
@aliscco aliscco mentioned this pull request Nov 28, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Nov 28, 2023
Open
This was referenced Nov 28, 2023
Open
Open
This was referenced Nov 29, 2023
Open
Open
This was referenced Nov 29, 2023
Open
Open
Open
@leonardoadame leonardoadame mentioned this pull request Nov 29, 2023
Open
@aliscco aliscco mentioned this pull request Nov 29, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Nov 29, 2023
Open
This was referenced Nov 30, 2023
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@hiroppy @mscdex @gibfahn @jasnell @lpinca @cjihrig @nodejs-github-bot