process: add NODE_NO_WARNINGS environment variable #10842

Merged
merged 1 commit into from Jan 19, 2017

Projects

None yet

8 participants

@cjihrig
Member
cjihrig commented Jan 16, 2017

This commit adds support for a NODE_NO_WARNINGS environment variable, which duplicates the functionality of the --no-warnings command line flag.

Fixes: #10802

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

process

@jasnell
Member
jasnell commented Jan 16, 2017

this is fine but I would very much also like to get #10116 landed in conjunction.

@cjihrig cjihrig process: add NODE_NO_WARNINGS environment variable
This commit adds support for a NODE_NO_WARNINGS environment
variable, which duplicates the functionality of the --no-warnings
command line flag.

Fixes: nodejs#10802
PR-URL: nodejs#10842
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
4990212
@cjihrig cjihrig merged commit 4990212 into nodejs:master Jan 19, 2017
@cjihrig cjihrig deleted the cjihrig:10802 branch Jan 19, 2017
@silverwind
Contributor

Should this be documented in --help?

@cjihrig
Member
cjihrig commented Jan 19, 2017

Yes. I searched the codebase for a couple other environment variables, and didn't end up in the --help section. We need a better way to keep the man page, docs, help, and whatever else better in sync.

@cjihrig cjihrig referenced this pull request Jan 20, 2017
Merged

src: add NODE_NO_WARNINGS to --help output #10918

3 of 3 tasks complete
@cjihrig
Member
cjihrig commented Jan 20, 2017

Added to --help in #10918

@silverwind
Contributor

I guess we could test if the CLI switches and environment variables are matching in the man page and --help. Checking the markdown too might be more complicated.

@cjihrig cjihrig added a commit to cjihrig/node-1 that referenced this pull request Jan 23, 2017
@cjihrig cjihrig src: add NODE_NO_WARNINGS to --help output
This commit adds a description of the NODE_NO_WARNINGS
environment variable to the --help output. This was overlooked
in 4990212.

Refs: nodejs#10842
PR-URL: nodejs#10918
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
f69e59d
@italoacasas italoacasas added a commit to italoacasas/node that referenced this pull request Jan 25, 2017
@cjihrig @italoacasas cjihrig + italoacasas process: add NODE_NO_WARNINGS environment variable
This commit adds support for a NODE_NO_WARNINGS environment
variable, which duplicates the functionality of the --no-warnings
command line flag.

Fixes: nodejs#10802
PR-URL: nodejs#10842
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
7212a2b
@italoacasas italoacasas added a commit to italoacasas/node that referenced this pull request Jan 27, 2017
@cjihrig @italoacasas cjihrig + italoacasas process: add NODE_NO_WARNINGS environment variable
This commit adds support for a NODE_NO_WARNINGS environment
variable, which duplicates the functionality of the --no-warnings
command line flag.

Fixes: nodejs#10802
PR-URL: nodejs#10842
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
d24491c
@targos targos added a commit that referenced this pull request Jan 28, 2017
@cjihrig @targos cjihrig + targos src: add NODE_NO_WARNINGS to --help output
This commit adds a description of the NODE_NO_WARNINGS
environment variable to the --help output. This was overlooked
in 4990212.

Refs: #10842
PR-URL: #10918
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
e08ddac
@italoacasas italoacasas referenced this pull request Jan 29, 2017
Merged

v7.5.0 proposal #11062

@italoacasas italoacasas added a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@cjihrig @italoacasas cjihrig + italoacasas src: add NODE_NO_WARNINGS to --help output
This commit adds a description of the NODE_NO_WARNINGS
environment variable to the --help output. This was overlooked
in 4990212.

Refs: nodejs#10842
PR-URL: nodejs#10918
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
cd94642
@italoacasas italoacasas added a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@cjihrig @italoacasas cjihrig + italoacasas src: add NODE_NO_WARNINGS to --help output
This commit adds a description of the NODE_NO_WARNINGS
environment variable to the --help output. This was overlooked
in 4990212.

Refs: nodejs#10842
PR-URL: nodejs#10918
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
3057c55
@evanlucas evanlucas added a commit that referenced this pull request Jan 31, 2017
@evanlucas evanlucas 2017-01-31, Version 7.5.0 (Current)
Notable changes:

* crypto:
  * ability to select cert store at runtime (Adam Majer) #8334
  * Use system CAs instead of using bundled ones (Adam Majer) #8334
* deps:
  * upgrade npm to 4.1.2 (Kat Marchán) #11020
  * upgrade openssl sources to 1.0.2k (Shigeki Ohtsu) #11021
* doc: add basic documentation for WHATWG URL API (James M Snell) #10620
* process: add NODE_NO_WARNINGS environment variable (cjihrig) #10842
* url: allow use of URL with http.request and https.request (James M Snell) #10638

PR-URL: #11062
42b4cee
@evanlucas evanlucas added a commit that referenced this pull request Jan 31, 2017
@evanlucas evanlucas 2017-01-31, Version 7.5.0 (Current)
Notable changes:

* crypto:
  * ability to select cert store at runtime (Adam Majer) #8334
  * Use system CAs instead of using bundled ones (Adam Majer) #8334
* deps:
  * upgrade npm to 4.1.2 (Kat Marchán) #11020
  * upgrade openssl sources to 1.0.2k (Shigeki Ohtsu) #11021
* doc: add basic documentation for WHATWG URL API (James M Snell) #10620
* process: add NODE_NO_WARNINGS environment variable (cjihrig) #10842
* url: allow use of URL with http.request and https.request (James M Snell) #10638

PR-URL: #11062
a34f1d6
@evanlucas evanlucas added a commit that referenced this pull request Feb 1, 2017
@evanlucas evanlucas 2017-01-31, Version 7.5.0 (Current)
Notable changes:

* crypto:
  * ability to select cert store at runtime (Adam Majer) #8334
  * Use system CAs instead of using bundled ones (Adam Majer) #8334
* deps:
  * upgrade npm to 4.1.2 (Kat Marchán) #11020
  * upgrade openssl sources to 1.0.2k (Shigeki Ohtsu) #11021
* doc: add basic documentation for WHATWG URL API (James M Snell) #10620
* process: add NODE_NO_WARNINGS environment variable (cjihrig) #10842
* url: allow use of URL with http.request and https.request (James M Snell) #10638

PR-URL: #11062
a1c91ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment