test: increase coverage of string-decoder #10863

hiroppy · 2017-01-18T04:43:20Z

Add normalizeencoding's test.
normalizeEncoding: https://github.com/nodejs/node/blob/master/lib/string_decoder.js#L9
Make use of Arrow Function.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

test

Trott · 2017-01-18T04:49:17Z

test/parallel/test-string-decoder-end.js

@@ -8,13 +8,13 @@ const assert = require('assert');
 const SD = require('string_decoder').StringDecoder;
 const encodings = ['base64', 'hex', 'utf8', 'utf16le', 'ucs2'];

-const bufs = [ '☃💩', 'asdf' ].map(function(b) {
+const bufs = [ '☃💩', 'asdf' ].map((b) => {


Optional: This could just be (b) => Buffer.from(b). (The current code base does have a mixture of using {...} and return when it's not required vs. omitting them, so either should be fine, but omitting them is definitely more common.)

Trott · 2017-01-18T04:49:52Z

test/parallel/test-string-decoder-end.js

  return Buffer.from(b);
 });

 // also test just arbitrary bytes from 0-15.
 for (let i = 1; i <= 16; i++) {
-  const bytes = new Array(i).join('.').split('.').map(function(_, j) {
+  const bytes = new Array(i).join('.').split('.').map((_, j) => {


Similarly, this arrow function could be (_, j) => j + 0x78 if you like.

mscdex · 2017-01-18T04:57:57Z

s/starting/string/ in commit message

hiroppy · 2017-01-18T04:59:50Z

Oops... updated. Thanks :)

lpinca · 2017-01-18T12:30:06Z

test/parallel/test-string-decoder.js

@@ -104,6 +104,14 @@ assert.strictEqual(decoder.write(Buffer.from('3DD8', 'hex')), '');
 assert.strictEqual(decoder.write(Buffer.from('4D', 'hex')), '');
 assert.strictEqual(decoder.end(), '\ud83d');

+assert.throws(() => {
+  decoder = new StringDecoder(1);


Nit: does the linter complain if the assignment is removed?

Nope. I deleted the assignment.

Make use of Arrow Function. Add normalizeencoding's test. normalizeEncoding: https://github.com/nodejs/node/blob/master/lib/string_decoder.js#L9

lpinca · 2017-01-18T16:04:35Z

CI: https://ci.nodejs.org/job/node-test-pull-request/5927/

addaleax · 2017-01-21T09:10:16Z

Landed in aebcc1a0d95b5f9e138da3c185c0ba25e5cd0fef

lpinca · 2017-01-21T09:12:13Z

@addaleax commit title seems a bit off: "starting-decoder"?

addaleax · 2017-01-21T09:14:22Z

@lpinca thanks for catching, force-pushed to fix 😅

Make use of Arrow Function. Add normalizeencoding's test. normalizeEncoding: https://github.com/nodejs/node/blob/master/lib/string_decoder.js#L9 PR-URL: #10863 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

hiroppy · 2017-01-21T09:15:23Z

Oops, I changed it with another PC. Sorry;(
@addaleax @lpinca Thanks!

Make use of Arrow Function. Add normalizeencoding's test. normalizeEncoding: https://github.com/nodejs/node/blob/master/lib/string_decoder.js#L9 PR-URL: #10863 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Make use of Arrow Function. Add normalizeencoding's test. normalizeEncoding: https://github.com/nodejs/node/blob/master/lib/string_decoder.js#L9 PR-URL: nodejs#10863 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Make use of Arrow Function. Add normalizeencoding's test. normalizeEncoding: https://github.com/nodejs/node/blob/master/lib/string_decoder.js#L9 PR-URL: #10863 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

jasnell · 2017-03-08T22:00:52Z

Landed in v6. This will need a backport PR if it needs to land on v4

Make use of Arrow Function. Add normalizeencoding's test. normalizeEncoding: https://github.com/nodejs/node/blob/master/lib/string_decoder.js#L9 PR-URL: #10863 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

nodejs-github-bot added test Issues and PRs related to the tests. dont-land-on-v7.x labels Jan 18, 2017

Trott reviewed Jan 18, 2017

View reviewed changes

hiroppy force-pushed the feature/increase-coverage-of-string-decoder branch from 46a0454 to 7d5c020 Compare January 18, 2017 04:58

nodejs-github-bot added the dont-land-on-v7.x label Jan 18, 2017

mscdex added string_decoder Issues and PRs related to the string_decoder subsystem. and removed dont-land-on-v7.x labels Jan 18, 2017

hiroppy force-pushed the feature/increase-coverage-of-string-decoder branch from 7d5c020 to 075cb4b Compare January 18, 2017 04:59

nodejs-github-bot added the dont-land-on-v7.x label Jan 18, 2017

hiroppy changed the title ~~test: increase coverage of starting-decoder~~ test: increase coverage of string-decoder Jan 18, 2017

mscdex removed the dont-land-on-v7.x label Jan 18, 2017

jasnell approved these changes Jan 18, 2017

View reviewed changes

lpinca reviewed Jan 18, 2017

View reviewed changes

lpinca approved these changes Jan 18, 2017

View reviewed changes

cjihrig approved these changes Jan 18, 2017

View reviewed changes

hiroppy force-pushed the feature/increase-coverage-of-string-decoder branch from 075cb4b to bed8892 Compare January 18, 2017 15:43

nodejs-github-bot added the dont-land-on-v7.x label Jan 18, 2017

test: increase coverage of starting-decoder

dfebdc6

Make use of Arrow Function. Add normalizeencoding's test. normalizeEncoding: https://github.com/nodejs/node/blob/master/lib/string_decoder.js#L9

hiroppy force-pushed the feature/increase-coverage-of-string-decoder branch from bed8892 to dfebdc6 Compare January 18, 2017 15:45

nodejs-github-bot added the dont-land-on-v7.x label Jan 18, 2017

lpinca removed the dont-land-on-v7.x label Jan 18, 2017

addaleax approved these changes Jan 21, 2017

View reviewed changes

addaleax closed this Jan 21, 2017

hiroppy deleted the feature/increase-coverage-of-string-decoder branch January 21, 2017 09:11

italoacasas mentioned this pull request Jan 25, 2017

Proposal to update v7.x-staging #10989

Closed

italoacasas mentioned this pull request Jan 29, 2017

v7.5.0 proposal #11062

Merged

jasnell added the dont-land-on-v4.x label Mar 8, 2017

MylesBorins mentioned this pull request Mar 9, 2017

v6.10.1 proposal #11759

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: increase coverage of string-decoder #10863

test: increase coverage of string-decoder #10863

hiroppy commented Jan 18, 2017 •

edited

Loading

Trott Jan 18, 2017

Trott Jan 18, 2017

mscdex commented Jan 18, 2017

hiroppy commented Jan 18, 2017

lpinca Jan 18, 2017

hiroppy Jan 18, 2017

lpinca commented Jan 18, 2017

addaleax commented Jan 21, 2017

lpinca commented Jan 21, 2017

addaleax commented Jan 21, 2017

hiroppy commented Jan 21, 2017 •

edited

Loading

jasnell commented Mar 8, 2017

test: increase coverage of string-decoder #10863

test: increase coverage of string-decoder #10863

Conversation

hiroppy commented Jan 18, 2017 • edited Loading

Checklist

Affected core subsystem(s)

Trott Jan 18, 2017

Choose a reason for hiding this comment

Trott Jan 18, 2017

Choose a reason for hiding this comment

mscdex commented Jan 18, 2017

hiroppy commented Jan 18, 2017

lpinca Jan 18, 2017

Choose a reason for hiding this comment

hiroppy Jan 18, 2017

Choose a reason for hiding this comment

lpinca commented Jan 18, 2017

addaleax commented Jan 21, 2017

lpinca commented Jan 21, 2017

addaleax commented Jan 21, 2017

hiroppy commented Jan 21, 2017 • edited Loading

jasnell commented Mar 8, 2017

hiroppy commented Jan 18, 2017 •

edited

Loading

hiroppy commented Jan 21, 2017 •

edited

Loading