test: increase coverage for URL.searchParams #10952

hiroppy · 2017-01-22T16:18:33Z

Add exceptions for all cases.
Add entries, keys and values files.(Validation tests and exception tests are included.)

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

test

cjihrig · 2017-01-22T21:16:46Z

test/parallel/test-whatwg-url-searchparams-values.js

+assert.strictEqual(typeof values[Symbol.iterator], 'function');
+assert.strictEqual(values.next().value, 'b');
+assert.strictEqual(values.next().value, 'd');
+assert.strictEqual(values.next().value, undefined);


Might be worth checking done here too.

TimothyGu

Most of these tests were actually derived from W3C's web-platform-tests, so I'm sure they would appreciate these changes as well.

TimothyGu · 2017-01-22T21:52:56Z

test/parallel/test-whatwg-url-searchparams-entries.js

+
+params = new URLSearchParams('a=b&c=d');
+const entries = params.entries();
+assert.strictEqual(typeof entries[Symbol.iterator], 'function');


Also useful might be making sure entries[Symbol.iterator]() === entries.

TimothyGu · 2017-01-22T21:53:34Z

test/parallel/test-whatwg-url-searchparams-entries.js

+assert.deepStrictEqual(entries.next(), {
+  value: undefined,
+  done: true
+});


You may also test calling entries.next again (to simulate overread).

TimothyGu · 2017-01-22T21:54:05Z

test/parallel/test-whatwg-url-searchparams-entries.js

+
+assert.throws(() => {
+  params.entries.call(undefined);
+}, /^TypeError: Value of `this` is not a URLSearchParams$/);


entries.next.call(undefined) should throw as well.

TimothyGu · 2017-01-22T22:00:14Z

test/parallel/test-whatwg-url-searchparams-foreach.js

+}, /^TypeError: Value of `this` is not a URLSearchParams$/);
+assert.throws(() => {
+  params.forEach();
+}, /^TypeError: The `callback` argument needs to be specified$/);


This test seems to overlap with a series of similar, but more comprehensive tests in #10905. I'm fine with keeping it in this PR, but I'd prefer just dropping it here.

TimothyGu · 2017-01-22T22:08:16Z

CI: https://ci.nodejs.org/job/node-test-pull-request/5984/

hiroppy · 2017-01-22T22:38:24Z

@TimothyGu Thank you for reviews. PTAL 9c326fe

EDIT: I'll squash.

TimothyGu

@abouthiroppy, this PR seems to stop working after ed0086f. Can you please rebase and make sure it works on master? Thanks.

TimothyGu · 2017-01-28T18:48:38Z

test/parallel/test-whatwg-url-searchparams-entries.js

+let params = m.searchParams;
+
+// Until we export URLSearchParams
+const URLSearchParams = params.constructor;


This is also not needed any more after 326e967.

hiroppy · 2017-01-29T03:10:49Z

@TimothyGu I rebased and confirmed that the test passed. Thanks.

TimothyGu · 2017-01-29T07:55:46Z

test/parallel/test-whatwg-url-searchparams-keys.js

+let params = m.searchParams;
+
+// Until we export URLSearchParams
+const URLSearchParams = params.constructor;


Actually do you mind fixing this and in -values.js as well?

const URLSearchParams = require('url').URLSearchParams;

Thanks, I forgot to change it.

Improve coverage for entries, keys and values. Validation tests and exception tests are included.

TimothyGu · 2017-01-29T08:31:03Z

Updated CI: https://ci.nodejs.org/job/node-test-pull-request/6094/

TimothyGu · 2017-01-29T09:47:30Z

Landed in e7f4825.

PR-URL: #10952 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

E.g. nodejs/node#10952

PR-URL: #10952 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

* index: allow #fragments in PR URLs Also check tightened PR_RE against pathname * review: fix Metadata state operation E.g. nodejs/node#10952 * review: simplify Fixes creation * review: overhaul getCollaborators() - Make regex static and more concise - Iterate over RE.exec - Use Map * review: remove extra whitespace Fixes: #5 * review: only look for LGTMs in <p>'s Fixes: nodejs/node#10657

nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 22, 2017

hiroppy force-pushed the feature/add-searchparams-tests branch 2 times, most recently from 8d0ef6f to c7f159a Compare January 22, 2017 16:22

mscdex added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Jan 22, 2017

cjihrig reviewed Jan 22, 2017

View reviewed changes

cjihrig approved these changes Jan 22, 2017

View reviewed changes

hiroppy force-pushed the feature/add-searchparams-tests branch from c7f159a to 91ec5aa Compare January 22, 2017 21:28

TimothyGu reviewed Jan 22, 2017

View reviewed changes

TimothyGu approved these changes Jan 22, 2017

View reviewed changes

hiroppy force-pushed the feature/add-searchparams-tests branch from 9c326fe to b031c07 Compare January 22, 2017 22:46

jasnell approved these changes Jan 23, 2017

View reviewed changes

joyeecheung approved these changes Jan 23, 2017

View reviewed changes

TimothyGu suggested changes Jan 28, 2017

View reviewed changes

test: add tests of error for searchParams

4fe75d4

hiroppy force-pushed the feature/add-searchparams-tests branch from b031c07 to 0626657 Compare January 29, 2017 03:08

TimothyGu approved these changes Jan 29, 2017

View reviewed changes

TimothyGu reviewed Jan 29, 2017

View reviewed changes

test: add tests of entries, keys, values for searchParams

189de74

Improve coverage for entries, keys and values. Validation tests and exception tests are included.

hiroppy force-pushed the feature/add-searchparams-tests branch from 0626657 to 189de74 Compare January 29, 2017 08:06

TimothyGu closed this Jan 29, 2017

TimothyGu moved this from doc / benchmark / test to Done in WHATWG URL implementation Jan 29, 2017

hiroppy deleted the feature/add-searchparams-tests branch January 29, 2017 09:53

TimothyGu added a commit to TimothyGu/node-review that referenced this pull request Jan 29, 2017

review: fix Metadata state operation

3939f18

E.g. nodejs/node#10952

TimothyGu mentioned this pull request Jan 29, 2017

Improvements nodejs/node-review#7

Merged

italoacasas mentioned this pull request Jan 31, 2017

v7.5.0 proposal #11062

Merged

jasnell added dont-land-on-v4.x labels Mar 8, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: increase coverage for URL.searchParams #10952

test: increase coverage for URL.searchParams #10952

hiroppy commented Jan 22, 2017

cjihrig Jan 22, 2017

TimothyGu left a comment

TimothyGu Jan 22, 2017

TimothyGu Jan 22, 2017

TimothyGu Jan 22, 2017

TimothyGu Jan 22, 2017

TimothyGu commented Jan 22, 2017

hiroppy commented Jan 22, 2017 •

edited

Loading

TimothyGu left a comment

TimothyGu Jan 28, 2017

hiroppy commented Jan 29, 2017

TimothyGu Jan 29, 2017

hiroppy Jan 29, 2017

TimothyGu commented Jan 29, 2017

TimothyGu commented Jan 29, 2017

test: increase coverage for URL.searchParams #10952

test: increase coverage for URL.searchParams #10952

Conversation

hiroppy commented Jan 22, 2017

Checklist

Affected core subsystem(s)

Choose a reason for hiding this comment

TimothyGu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TimothyGu commented Jan 22, 2017

hiroppy commented Jan 22, 2017 • edited Loading

TimothyGu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hiroppy commented Jan 29, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TimothyGu commented Jan 29, 2017

TimothyGu commented Jan 29, 2017

hiroppy commented Jan 22, 2017 •

edited

Loading