Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: minor fix for ReadableState #11139

Closed
wants to merge 2 commits into from
Closed

stream: minor fix for ReadableState #11139

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a43698
stream: remove unused `ranOut` from ReadableState
Feb 3, 2017
5315409
stream: fix comments for sync flag of ReadableState
Feb 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions lib/_stream_readable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@ function ReadableState(options, stream) {
this.endEmitted = false;
this.reading = false;

// a flag to be able to tell if the onwrite cb is called immediately,
// or on a later tick. We set this to true at first, because any
// actions that shouldn't happen until "later" should generally also
// not happen before the first write call.
// a flag to be able to tell if the event 'readable'/'data' is emitted
// immediately, or on a later tick. We set this to true at first, because
// any actions that shouldn't happen until "later" should generally also
// not happen before the first read call.
this.sync = true;

// whenever we return null, then we set a flag to say
Expand All @@ -81,10 +81,6 @@ function ReadableState(options, stream) {
// Everything else in the universe uses 'utf8', though.
this.defaultEncoding = options.defaultEncoding || 'utf8';

// when piping, we only care about 'readable' events that happen
// after read()ing all the bytes and not getting any pushback.
this.ranOut = false;

// the number of writers that are awaiting a drain event in .pipe()s
this.awaitDrain = 0;

Expand Down