New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src, inspector: add --inspect-brk option (backport 7.x) #11149

Merged
merged 1 commit into from Feb 7, 2017

Conversation

Projects
None yet
6 participants
@joshgav
Member

joshgav commented Feb 3, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

src, inspector


Backport of #8979 to 7.x-staging.

add an --inspect-brk option which breaks on first line of user script. same behavior as old --debug-brk flag.

@eugeneo

eugeneo approved these changes Feb 3, 2017

@jasnell

jasnell approved these changes Feb 3, 2017

@mscdex mscdex added inspector and removed debugger labels Feb 3, 2017

@joshgav joshgav referenced this pull request Feb 3, 2017

Merged

inspector: add --inspect-brk flag #8979

4 of 4 tasks complete
@italoacasas

This comment has been minimized.

Show comment
Hide comment
Member

italoacasas commented Feb 6, 2017

(7.x backport) src, inspector: add --inspect-brk
add an --inspect-brk option which breaks on
first line of user script. same behavior as old
--debug-brk flag.

PR-URL: #11149
Reviewed-By: Eugene Ostroukhov <eostroukhov@chromium.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
@joshgav

This comment has been minimized.

Show comment
Hide comment
@joshgav

joshgav Feb 7, 2017

Member

CI completed successfully: https://ci.nodejs.org/job/node-test-pull-request/6259/; ARM failure is a false positive.

Landed in 3a57c59.

Member

joshgav commented Feb 7, 2017

CI completed successfully: https://ci.nodejs.org/job/node-test-pull-request/6259/; ARM failure is a false positive.

Landed in 3a57c59.

@joshgav joshgav merged commit 3a57c59 into nodejs:v7.x-staging Feb 7, 2017

10 of 11 checks passed

test/arm tests failed!
Details
linter no errors found
Details
test/aix all tests passed
Details
test/freebsd all tests passed
Details
test/linux all tests passed
Details
test/linux-fips all tests passed
Details
test/linux-one all tests passed
Details
test/osx all tests passed
Details
test/ppc-linux all tests passed
Details
test/smartos all tests passed
Details
test/windows-fanned all tests passed
Details

joshgav added a commit to joshgav/node that referenced this pull request Feb 7, 2017

src, inspector: add --inspect-brk
add an --inspect-brk option which breaks on
first line of user script. same behavior as old
--debug-brk flag.

PR-URL: nodejs#11149
Reviewed-By: Eugene Ostroukhov <eostroukhov@chromium.org>
Reviewed-By: James M Snell <jasnell@gmail.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

src, inspector: add --inspect-brk
add an --inspect-brk option which breaks on
first line of user script. same behavior as old
--debug-brk flag.

PR-URL: nodejs#11149
Reviewed-By: Eugene Ostroukhov <eostroukhov@chromium.org>
Reviewed-By: James M Snell <jasnell@gmail.com>

italoacasas added a commit that referenced this pull request Feb 16, 2017

2017-02-21, Version 7.6.0 (Current)
Notable changes:

* deps:
    * update V8 to 5.5 (Michaël Zasso) [#11029](#11029)
    * upgrade libuv to 1.11.0 (cjihrig) [#11094](#11094)
    * add node-inspect 1.10.2 (Jan Krems) [#10187](#10187)
* lib: build `node inspect` into `node` (Anna Henningsen) [#10187](#10187)
* crypto: Remove expired certs from CNNIC whitelist (Shigeki Ohtsu) [#9469](#9469)
* inspector: add --inspect-brk (Josh Gavant) [#11149](#11149)
* fs: allow WHATWG URL and file: URLs as paths (James M Snell) [#10739](#10739)
* src: support UTF-8 in compiled-in JS source files (Ben Noordhuis) [#11129](#11129)
* url: extend url.format to support WHATWG URL (James M Snell) [#10857](#10857)

PR-URL: #11185

addaleax added a commit that referenced this pull request Feb 21, 2017

2017-02-21, Version 7.6.0 (Current)
Notable changes:

* deps:
    * update V8 to 5.5 (Michaël Zasso) [#11029](#11029)
    * upgrade libuv to 1.11.0 (cjihrig) [#11094](#11094)
    * add node-inspect 1.10.4 (Jan Krems) [#10187](#10187)
* lib: build `node inspect` into `node` (Anna Henningsen) [#10187](#10187)
* crypto: Remove expired certs from CNNIC whitelist (Shigeki Ohtsu) [#9469](#9469)
* inspector: add --inspect-brk (Josh Gavant) [#11149](#11149)
* fs: allow WHATWG URL objects as paths (James M Snell) [#10739](#10739)
* src: support UTF-8 in compiled-in JS source files (Ben Noordhuis) [#11129](#11129)
* url: extend url.format to support WHATWG URL (James M Snell) [#10857](#10857)

PR-URL: #11185

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 21, 2017

2017-02-21, Version 7.6.0 (Current)
Notable changes:

* deps:
    * update V8 to 5.5 (Michaël Zasso) [#11029](nodejs#11029)
    * upgrade libuv to 1.11.0 (cjihrig) [#11094](nodejs#11094)
    * add node-inspect 1.10.4 (Jan Krems) [#10187](nodejs#10187)
    * upgrade zlib to 1.2.11 (Sam Roberts) [#10980](nodejs#10980)
* lib: build `node inspect` into `node` (Anna Henningsen) [#10187](nodejs#10187)
* crypto: Remove expired certs from CNNIC whitelist (Shigeki Ohtsu) [#9469](nodejs#9469)
* inspector: add --inspect-brk (Josh Gavant) [#11149](nodejs#11149)
* fs: allow WHATWG URL objects as paths (James M Snell) [#10739](nodejs#10739)
* src: support UTF-8 in compiled-in JS source files (Ben Noordhuis) [#11129](nodejs#11129)
* url: extend url.format to support WHATWG URL (James M Snell) [#10857](nodejs#10857)

PR-URL: nodejs#11185

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 22, 2017

2017-02-21, Version 7.6.0 (Current)
Notable changes:

* deps:
    * update V8 to 5.5 (Michaël Zasso) [#11029](nodejs#11029)
    * upgrade libuv to 1.11.0 (cjihrig) [#11094](nodejs#11094)
    * add node-inspect 1.10.4 (Jan Krems) [#10187](nodejs#10187)
    * upgrade zlib to 1.2.11 (Sam Roberts) [#10980](nodejs#10980)
* lib: build `node inspect` into `node` (Anna Henningsen) [#10187](nodejs#10187)
* crypto: Remove expired certs from CNNIC whitelist (Shigeki Ohtsu) [#9469](nodejs#9469)
* inspector: add --inspect-brk (Josh Gavant) [#11149](nodejs#11149)
* fs: allow WHATWG URL objects as paths (James M Snell) [#10739](nodejs#10739)
* src: support UTF-8 in compiled-in JS source files (Ben Noordhuis) [#11129](nodejs#11129)
* url: extend url.format to support WHATWG URL (James M Snell) [#10857](nodejs#10857)

PR-URL: nodejs#11185

imyller added a commit to imyller/meta-nodejs that referenced this pull request Mar 2, 2017

2017-02-21, Version 7.6.0 (Current)
    Notable changes:

    * deps:
        * update V8 to 5.5 (Michaël Zasso) [#11029](nodejs/node#11029)
        * upgrade libuv to 1.11.0 (cjihrig) [#11094](nodejs/node#11094)
        * add node-inspect 1.10.4 (Jan Krems) [#10187](nodejs/node#10187)
        * upgrade zlib to 1.2.11 (Sam Roberts) [#10980](nodejs/node#10980)
    * lib: build `node inspect` into `node` (Anna Henningsen) [#10187](nodejs/node#10187)
    * crypto: Remove expired certs from CNNIC whitelist (Shigeki Ohtsu) [#9469](nodejs/node#9469)
    * inspector: add --inspect-brk (Josh Gavant) [#11149](nodejs/node#11149)
    * fs: allow WHATWG URL objects as paths (James M Snell) [#10739](nodejs/node#10739)
    * src: support UTF-8 in compiled-in JS source files (Ben Noordhuis) [#11129](nodejs/node#11129)
    * url: extend url.format to support WHATWG URL (James M Snell) [#10857](nodejs/node#10857)

    PR-URL: nodejs/node#11185

Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment