Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport of 11074 - doc: replace newlines in deprecation with space #11178

Closed

Conversation

thefourtheye
Copy link
Contributor

Backport of #11074

As it is, each line in the deprecation heading which are wrapped at 80
characters in the *.md files, are shown in different lines. For example

> Stability: 0 - Deprecated: Use
> `Buffer.from(arrayBuffer[, byteOffset [, length]])`
> instead.

is shown in three different lines. This patch replaces the newlines
with space characters, so that the output will be in single line.

PR-URL: #11074

Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: Jeremiah Senkpiel fishrock123@rocketmail.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Timothy Gu timothygu99@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Michaël Zasso targos@protonmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

As it is, each line in the deprecation heading which are wrapped at 80
characters in the *.md files, are shown in different lines. For example

    > Stability: 0 - Deprecated: Use
    > `Buffer.from(arrayBuffer[, byteOffset [, length]])`
    > instead.

is shown in three different lines. This patch replaces the newlines
with space characters, so that the output will be in single line.

PR-URL: nodejs#11074

Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@nodejs-github-bot nodejs-github-bot added tools Issues and PRs related to the tools directory. v6.x labels Feb 5, 2017
@MylesBorins
Copy link
Contributor

@thefourtheye this was already cherry-picked in f62b879

@thefourtheye thefourtheye deleted the backport-11074-v6.x branch February 22, 2017 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants