build: disable C4267 conversion compiler warning #11205

Merged
merged 1 commit into from Feb 9, 2017

Conversation

Projects
None yet
5 participants
@bnoordhuis
Member

bnoordhuis commented Feb 6, 2017

Disable "warning C4267: conversion from 'size_t' to 'int', possible
loss of data". Many originate from our dependencies and their sheer
number drowns out other, more legitimate warnings.

CI: https://ci.nodejs.org/job/node-test-pull-request/6246/

@jasnell

jasnell approved these changes Feb 6, 2017

@cjihrig

cjihrig approved these changes Feb 6, 2017

@mhdawson

LGTM with a question. Is it possible to disable for specific files/directories or is it all or nothing ?

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis Feb 7, 2017

Member

Not on a file or directory basis but it can be set on a per-target basis.

Member

bnoordhuis commented Feb 7, 2017

Not on a file or directory basis but it can be set on a per-target basis.

build: disable C4267 conversion compiler warning
Disable "warning C4267: conversion from 'size_t' to 'int', possible
loss of data".  Many originate from our dependencies and their sheer
number drowns out other, more legitimate warnings.

PR-URL: #11205
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@bnoordhuis bnoordhuis closed this Feb 9, 2017

@bnoordhuis bnoordhuis deleted the bnoordhuis:msvs-disable-c4267 branch Feb 9, 2017

@bnoordhuis bnoordhuis merged commit 97ebdf3 into nodejs:master Feb 9, 2017

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 9, 2017

build: disable C4267 conversion compiler warning
Disable "warning C4267: conversion from 'size_t' to 'int', possible
loss of data".  Many originate from our dependencies and their sheer
number drowns out other, more legitimate warnings.

PR-URL: nodejs#11205
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

build: disable C4267 conversion compiler warning
Disable "warning C4267: conversion from 'size_t' to 'int', possible
loss of data".  Many originate from our dependencies and their sheer
number drowns out other, more legitimate warnings.

PR-URL: nodejs#11205
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

KryDos added a commit to KryDos/node that referenced this pull request Feb 25, 2017

build: disable C4267 conversion compiler warning
Disable "warning C4267: conversion from 'size_t' to 'int', possible
loss of data".  Many originate from our dependencies and their sheer
number drowns out other, more legitimate warnings.

PR-URL: nodejs#11205
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

jasnell added a commit that referenced this pull request Mar 7, 2017

build: disable C4267 conversion compiler warning
Disable "warning C4267: conversion from 'size_t' to 'int', possible
loss of data".  Many originate from our dependencies and their sheer
number drowns out other, more legitimate warnings.

PR-URL: #11205
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

jasnell added a commit that referenced this pull request Mar 7, 2017

build: disable C4267 conversion compiler warning
Disable "warning C4267: conversion from 'size_t' to 'int', possible
loss of data".  Many originate from our dependencies and their sheer
number drowns out other, more legitimate warnings.

PR-URL: #11205
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

MylesBorins added a commit that referenced this pull request Mar 9, 2017

build: disable C4267 conversion compiler warning
Disable "warning C4267: conversion from 'size_t' to 'int', possible
loss of data".  Many originate from our dependencies and their sheer
number drowns out other, more legitimate warnings.

PR-URL: #11205
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@MylesBorins MylesBorins referenced this pull request Mar 9, 2017

Merged

v6.10.1 proposal #11759

MylesBorins added a commit that referenced this pull request Mar 9, 2017

build: disable C4267 conversion compiler warning
Disable "warning C4267: conversion from 'size_t' to 'int', possible
loss of data".  Many originate from our dependencies and their sheer
number drowns out other, more legitimate warnings.

PR-URL: #11205
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@MylesBorins MylesBorins referenced this pull request Mar 9, 2017

Merged

v4.8.1 proposal #11760

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment