test: fix incorrect indentation #11219

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
8 participants
@cjihrig
Contributor

cjihrig commented Feb 7, 2017

Indentaiton is off in test-http-server-unconsume-consume.js. The linter isn't complaining, but it probably should be.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

test: fix incorrect indentation
Indentaiton is off in test-http-server-unconsume-consume.js.
The linter isn't complaining, but it probably should be.
@bnoordhuis

LGTM, although if the linter isn't complaining...

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Feb 7, 2017

Contributor

I'm more curious as to why the linter isn't complaining. I experimented with the file a little bit, and it wasn't complaining at other incorrect indentation levels. cc: @not-an-aardvark

Contributor

cjihrig commented Feb 7, 2017

I'm more curious as to why the linter isn't complaining. I experimented with the file a little bit, and it wasn't complaining at other incorrect indentation levels. cc: @not-an-aardvark

@not-an-aardvark

This comment has been minimized.

Show comment
Hide comment
@not-an-aardvark

not-an-aardvark Feb 7, 2017

Member

It's happening because we have the ObjectExpression: first option configured, which verifies that all properties must be aligned with the first property, but is designed to not validate the indentation of the first property. In the next major release, it's likely that the linter will validate that the first property has the normal level of indentation.

Member

not-an-aardvark commented Feb 7, 2017

It's happening because we have the ObjectExpression: first option configured, which verifies that all properties must be aligned with the first property, but is designed to not validate the indentation of the first property. In the next major release, it's likely that the linter will validate that the first property has the normal level of indentation.

@jasnell

jasnell approved these changes Feb 7, 2017

@mscdex mscdex added the http label Feb 7, 2017

@mscdex

This comment has been minimized.

Show comment
Hide comment
@mscdex

mscdex Feb 7, 2017

Contributor

Minor nit: there's a typo in the commit message.

Contributor

mscdex commented Feb 7, 2017

Minor nit: there's a typo in the commit message.

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Feb 9, 2017

Contributor

Landed in c239581. Thanks.

Contributor

cjihrig commented Feb 9, 2017

Landed in c239581. Thanks.

@cjihrig cjihrig closed this Feb 9, 2017

@cjihrig cjihrig deleted the cjihrig:indentation branch Feb 9, 2017

cjihrig added a commit that referenced this pull request Feb 9, 2017

test: fix incorrect indentation
Indentation is off in test-http-server-unconsume-consume.js.
The linter isn't complaining, but it probably should be.

PR-URL: #11219
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

italoacasas added a commit that referenced this pull request Feb 13, 2017

test: fix incorrect indentation
Indentation is off in test-http-server-unconsume-consume.js.
The linter isn't complaining, but it probably should be.

PR-URL: #11219
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

test: fix incorrect indentation
Indentation is off in test-http-server-unconsume-consume.js.
The linter isn't complaining, but it probably should be.

PR-URL: nodejs#11219
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

KryDos added a commit to KryDos/node that referenced this pull request Feb 25, 2017

test: fix incorrect indentation
Indentation is off in test-http-server-unconsume-consume.js.
The linter isn't complaining, but it probably should be.

PR-URL: nodejs#11219
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment