Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor test-http-response-statuscode #11274

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Feb 9, 2017

  • move repeated code to function
  • use strings for expected error (exposes result for [] as empty string)
  • remove unneeded common.mustCall() usage with function arguments that
    are not callbacks
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test http

test: refactor test-http-response-statuscode
* move repeated code to function
* use strings for expected error (exposes result for [] as empty string)
* remove unneeded `common.mustCall()` usage with function arguments that
  are not callbacks

@Trott Trott added the http label Feb 9, 2017

@cjihrig
cjihrig approved these changes Feb 9, 2017
@jasnell
jasnell approved these changes Feb 9, 2017
@Trott

This comment has been minimized.

Copy link
Member Author

commented Feb 10, 2017

@Trott

This comment has been minimized.

Copy link
Member Author

commented Feb 13, 2017

Landed in dd1cf8b

@Trott Trott closed this Feb 13, 2017

Trott added a commit that referenced this pull request Feb 13, 2017
test: refactor test-http-response-statuscode
* move repeated code to function
* use strings for expected error (exposes result for [] as empty string)
* remove unneeded `common.mustCall()` usage with function arguments that
  are not callbacks

PR-URL: #11274
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@italoacasas

This comment has been minimized.

Copy link
Member

commented Feb 14, 2017

@Trott this is not landing in v7 clearly, any plan to backport?

@Trott

This comment has been minimized.

Copy link
Member Author

commented Feb 14, 2017

@italoacasas It depends on #11221 which is semver-major. I think it's OK to not land this one on 7.x.x.

@notarseniy notarseniy referenced this pull request Feb 16, 2017
2 of 2 tasks complete
KryDos added a commit to KryDos/node that referenced this pull request Feb 25, 2017
test: refactor test-http-response-statuscode
* move repeated code to function
* use strings for expected error (exposes result for [] as empty string)
* remove unneeded `common.mustCall()` usage with function arguments that
  are not callbacks

PR-URL: nodejs#11274
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@jasnell jasnell referenced this pull request Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.