Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: do not leak handles on debug and exit #1133

Closed
wants to merge 1 commit into from
Closed

src: do not leak handles on debug and exit #1133

wants to merge 1 commit into from

Conversation

indutny
Copy link
Member

@indutny indutny commented Mar 12, 2015

Ensure HandleScope is created before creating any new handles (which
Context::Scope and Environment::GetCurrent does).

cc @iojs/collaborators @trevnorris @bnoordhuis

I have identified these with the help of : https://codereview.chromium.org/985873002/

@indutny
src: do not leak handles on debug and exit
6941d1b 
Ensure HandleScope is created before creating any new handles (which
`Context::Scope` and `Environment::GetCurrent` does).
@indutny
Copy link
Member Author

indutny commented Mar 12, 2015

CI: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/287/

@bnoordhuis
Copy link
Member

Nice! (And obvious in retrospect. :-)) LGTM.

@indutny
Copy link
Member Author

indutny commented Mar 12, 2015

Thanks!

@rvagg
Copy link
Member

rvagg commented Mar 12, 2015

sweet, LGTM, but sadly I don't imagine these particular ones would impact the apparent leak in #1075 unless I'm missing something

@mscdex
Copy link
Contributor

mscdex commented Mar 12, 2015

LGTM

@indutny
Copy link
Member Author

indutny commented Mar 12, 2015

@rvagg they won't for sure. I'm still don't know what kind of leak are we dealing with in #1075: JS heap, or C++ heap. Might be both, who knows!

indutny added a commit that referenced this pull request Mar 12, 2015
@indutny
src: do not leak handles on debug and exit
e2c9040 
Ensure HandleScope is created before creating any new handles (which
`Context::Scope` and `Environment::GetCurrent` does).

PR-URL: #1133
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Brian White <mscdex@mscdex.net>
@indutny
Copy link
Member Author

indutny commented Mar 12, 2015

Landed in e2c9040, thanks everyone!

@indutny indutny closed this Mar 12, 2015
@indutny indutny deleted the feature/no-more-leaks branch March 12, 2015 21:52
@rvagg rvagg mentioned this pull request Mar 14, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@indutny @bnoordhuis @rvagg @mscdex