New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update link to V8 Embedder's guide #11336

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
6 participants
@fhinkel
Member

fhinkel commented Feb 13, 2017

V8 moved the Embeder's guide to GitHub.

Checklist
  • documentation is changed or added
Affected core subsystem(s)

doc

doc: update link to V8 Embedder's guide
V8 moved the Embeder's guide to GitHub.

@fhinkel fhinkel added the doc label Feb 13, 2017

@jasnell

This shouldn't need the full 48 hours to land

@targos

targos approved these changes Feb 13, 2017

@lpinca

lpinca approved these changes Feb 13, 2017

fhinkel added a commit to fhinkel/node that referenced this pull request Feb 14, 2017

doc: update link to V8 Embedder's guide
V8 moved the Embeder's guide to GitHub.

PR-URL: nodejs#11336
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@fhinkel

This comment has been minimized.

Show comment
Hide comment
@fhinkel

fhinkel Feb 14, 2017

Member

Landed in 76ba3bf

Member

fhinkel commented Feb 14, 2017

Landed in 76ba3bf

@fhinkel fhinkel closed this Feb 14, 2017

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

doc: update link to V8 Embedder's guide
V8 moved the Embeder's guide to GitHub.

PR-URL: nodejs#11336
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

jasnell added a commit that referenced this pull request Mar 7, 2017

doc: update link to V8 Embedder's guide
V8 moved the Embeder's guide to GitHub.

PR-URL: #11336
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit that referenced this pull request Mar 9, 2017

doc: update link to V8 Embedder's guide
V8 moved the Embeder's guide to GitHub.

PR-URL: #11336
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@MylesBorins MylesBorins referenced this pull request Mar 9, 2017

Merged

v6.10.1 proposal #11759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment