lib: remove simd support from util.format() #11346
Conversation
Upstream V8 is removing SIMD support. Be proactive and follow suit. Refs: https://bugs.chromium.org/p/v8/issues/detail?id=4124
nodejs-github-bot
added
the
util
|
should this actually go through a deprecation cycle tho? Is this still considered experimental? |
|
Shouldn't the second commit message use |
Because of CI failures. Temporary respite.
It's never been non-experimental. :-)
I can update that. |
|
cc @fhinkel - I saw you reverted the V8 CL for breaking the integration build. |
|
@jasnell This probably doesn't need a deprecation cycle because it never worked without |
|
@bnoordhuis yes, I wanted to keep the build green. I deleted the test in V8's Node fork and relanded the CL this morning, i.e., no simd.js in V8 master anymore! I think @targos usually picks up the changes on V8's node fork when updating to a newer V8 version. But I guess removing support from master before current V8 lands doesn't hurt either. +1 on removing an experimental feature without deprecation cycle. We continuously integrate V8 master in Node. If anybody's interested: CI, V8's fork of Node. |
|
@nodejs/ctc — do we consider changes or removal of flagged features as a semver-major or not? |
|
I'm good with semver-major to be on the safe side |
jasnell
added
the
semver-major
|
Not entirely related, but what is the reason for dropping |
|
IANAV8TM (I Am Not A V8 Team Member) but it looks like it was partially maintenance effort, partially binary size. Someone reported that the Chrome .apk shrunk by almost 500 kB after removing SIMD.js. |
PR-URL: #11346 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Upstream V8 is removing SIMD support. Be proactive and follow suit. Refs: https://bugs.chromium.org/p/v8/issues/detail?id=4124 PR-URL: #11346 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Landed in c5d1851...2ba4eea |
|
For anyone further interested: https://bugs.chromium.org/p/v8/issues/detail?id=6020&desc=2
|
Upstream V8 is removing SIMD support. Be proactive and follow suit.
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=4124
I figured that since it's going away anyway, we may save ourselves some maintenance work by removing it now rather than waiting until the V8 release that drops SIMD support. (And also because I'll probably forget if I don't act on it immediately.)
If people feel it's premature, I'm happy to postpone. The first commit does some minor cleanup and can land either way.