Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors, events: migrate to internal/errors.js #11400

Closed
wants to merge 4 commits into from
Closed

errors, events: migrate to internal/errors.js #11400

wants to merge 4 commits into from

Conversation

shubheksha
Copy link
Contributor

Fixes #11273

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

errors, events, test

- Replaced existing error messages with new error codes
- Fix failing tests
Replaced functions to use arrow functions wherever possible
Replaced existing functions with arrow functions wherever possible
@nodejs-github-bot nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. events Issues and PRs related to the events subsystem / EventEmitter. labels Feb 15, 2017
@joyeecheung joyeecheung added the semver-major PRs that contain breaking changes and should be released in the next major version. label Feb 15, 2017
@joyeecheung
Copy link
Member

@jasnell jasnell added the blocked PRs that are blocked by other issues or PRs. label Apr 5, 2017
@fhinkel
Copy link
Member

fhinkel commented May 23, 2017

@shubheksha Thanks so much for putting this together. Sorry that it is dragging out for so long due to being a semver-major change. Could you rebase and also squash your commits (I think all the changes should be 1 commit, right?). Thanks!

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

mhdawson commented Jun 6, 2017

@shubheksha if you rebase I'll go ahead and land assuming the CI passes.

@fhinkel fhinkel added the stalled Issues and PRs that are stalled. label Jun 7, 2017
@mhdawson
Copy link
Member

@shubheksha just wondering if you are going to be able to rebase this or need any help ?

@fhinkel
Copy link
Member

fhinkel commented Jun 28, 2017

I'm closing this because it's been inactive for quite a while. Feel free to reopen or ping a collaborator to get it reopened if needed.

@fhinkel fhinkel closed this Jun 28, 2017
@refack
Copy link
Contributor

refack commented Jul 19, 2017

I'll follow up

@refack refack reopened this Jul 19, 2017
@refack refack removed the blocked PRs that are blocked by other issues or PRs. label Jul 19, 2017
@refack refack self-assigned this Jul 19, 2017
@refack refack removed the stalled Issues and PRs that are stalled. label Jul 19, 2017
@refack
Copy link
Contributor

refack commented Jul 19, 2017

I'll follow up

@mhdawson
Copy link
Member

@refack what do you mean by "I'll follow up". Its been a while so I'm wondering what we should do with this one.

@refack refack added this to In Progress in Error Codes Aug 20, 2017
@BridgeAR
Copy link
Member

BridgeAR commented Sep 8, 2017

Ping @refack

@BridgeAR
Copy link
Member

Closing due to the long inactivity.

@shubheksha if you would like to pursue this further, please feel free to leave a comment or to open a new PR! I am sorry this could not land as is and your contribution is highly appreciated nevertheless.

@BridgeAR BridgeAR closed this Sep 23, 2017
@jasnell jasnell moved this from In Progress to Done in Error Codes Oct 25, 2017
@refack refack removed their assignment Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
errors Issues and PRs related to JavaScript errors originated in Node.js core. events Issues and PRs related to the events subsystem / EventEmitter. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
No open projects
Error Codes
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

8 participants