Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
napi: change napi_callback to return napi_value #12248
When we invoke the callback, we will check the return value and call
Remove all of the
Update all the test collateral according to these changes. Also add
Affected core subsystem(s)
please fix up and make sure to run make test
Landed in ca786c3
(@nodejs/build … any idea what’s up with the osx CI not running?)
Also, for future reference: It would be cool if you could use
@addaleax Thanks very much for your help with this PR!
I tried really hard to make the commit message match the requirements so sorry if I got that wrong - does the 72 character limit include some spaces at the beginning which I didn't add? Do the commit message rules apply to all of the commits or just the final squashed commit (which is what I imagine you actually pushed) and did you pull the message from the PR or the commits themselves?
Also, yeah, I actually didn't realize one backtick worked for inline code until recently since I tend to use multi-line code blocks with syntax highlighting.
No, but maybe something got messed up while editing the commit message? Most of the lines in 8f34553 are longer than 72 chars (
Heh, looks like I should have pulled it from the PR description. ;) But yes, just the final squashed commit(s) that get merged. What you do inside the PR is completely up to you – rebase, squash, amend, or add commits in any way that you think makes sense. :)