Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc, tools: add doc linting to CI #12640

Closed
wants to merge 1 commit into from
Closed

doc, tools: add doc linting to CI #12640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Expand Up @@ -861,7 +861,7 @@ jslint:
jslint-ci:
@echo "Running JS linter..."
$(NODE) tools/jslint.js $(PARALLEL_ARGS) -f tap -o test-eslint.tap \
benchmark lib test tools
benchmark doc lib test tools

CPPLINT_EXCLUDE ?=
CPPLINT_EXCLUDE += src/node_root_certs.h
Expand Down
4 changes: 3 additions & 1 deletion tools/jslint.js
View file
Open in desktop
@@ -1,6 +1,7 @@
'use strict';

const rulesDirs = ['tools/eslint-rules'];
const extensions = ['.js', '.md'];
// This is the maximum number of files to be linted per worker at any given time
const maxWorkload = 40;

Expand All @@ -14,7 +15,8 @@ const glob = require('./eslint/node_modules/glob');

const cwd = process.cwd();
const cliOptions = {
rulePaths: rulesDirs
rulePaths: rulesDirs,
extensions: extensions,
};

// Check if we should fix errors that are fixable
Expand Down
2 changes: 1 addition & 1 deletion vcbuild.bat
View file
Open in desktop
Expand Up @@ -426,7 +426,7 @@ goto exit

:jslint-ci
echo running jslint-ci
%config%\node tools\jslint.js -J -f tap -o test-eslint.tap benchmark lib test tools
%config%\node tools\jslint.js -J -f tap -o test-eslint.tap benchmark doc lib test tools
goto exit

:no-lint
Expand Down