Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc, tools: add doc linting to CI #12640

Closed
wants to merge 1 commit into from

Conversation

@vsemozhetbyt
Copy link
Contributor

commented Apr 25, 2017

Checklist
Affected core subsystem(s)

doc, tools

Fixes: #12635
Refs: #12563

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2017

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2017

Just 1 Windows machine unstable in CI.

For a test, I shall add an error in doc and run a new CI.

@vsemozhetbyt vsemozhetbyt force-pushed the vsemozhetbyt:doc-lint-ci branch Apr 25, 2017

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2017

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2017

Whohoo! Linter fails.

Do I get it right that linter in CI is run only as a separate job and is not run in builds? So we can test only Makefile here and not vcbuild.bat?

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2017

It seems so, as only the linter job fails. Reverting the error...

@vsemozhetbyt vsemozhetbyt force-pushed the vsemozhetbyt:doc-lint-ci branch to 3318ea5 Apr 25, 2017

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2017

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2017

Please, let me know if this can be landed without delay as a follow-up fix for #12563. Currently, we have a conflict between local and CI linting. We can land commits that will break ESLint runs in local buildings.

cc @not-an-aardvark, @silverwind, @Trott

@vsemozhetbyt vsemozhetbyt referenced this pull request Apr 25, 2017
3 of 3 tasks complete
@not-an-aardvark
Copy link
Member

left a comment

The changes LGTM, but I'll defer to others about whether this should be landed without waiting 48 hours.

@mhdawson
Copy link
Member

left a comment

LGTM

@gibfahn

This comment has been minimized.

Copy link
Member

commented Apr 25, 2017

+1 to landing sooner to avoid CI/local linting issues

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2017

I will dare to land now having got a one +1 and some LGTM.

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2017

Landed in 42dca99

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:doc-lint-ci branch Apr 25, 2017

vsemozhetbyt added a commit that referenced this pull request Apr 25, 2017
doc, tools: add doc linting to CI
PR-URL: #12640
Fixes: #12635
Refs: #12563
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2017

It seems all the old PRs will still use the old linting in CI if not rebased.

The same example: #12549 (comment)

New linter CI was launched after landing this PR, but console log shows old linting commands: https://ci.nodejs.org/job/node-test-linter/8559/console

I think this is an additional reason for having this landed sooner.

@evanlucas evanlucas referenced this pull request May 1, 2017
evanlucas added a commit that referenced this pull request May 1, 2017
doc, tools: add doc linting to CI
PR-URL: #12640
Fixes: #12635
Refs: #12563
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
evanlucas added a commit that referenced this pull request May 2, 2017
doc, tools: add doc linting to CI
PR-URL: #12640
Fixes: #12635
Refs: #12563
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@vsemozhetbyt vsemozhetbyt referenced this pull request May 16, 2017
2 of 2 tasks complete
@gibfahn

This comment has been minimized.

Copy link
Member

commented May 16, 2017

Will be backported to v6.x with #12563 if that lands.

@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
vsemozhetbyt added a commit to vsemozhetbyt/node that referenced this pull request Jul 10, 2017
build, doc, tools: add eslint-plugin-markdown
* Install eslint-plugin-markdown@1.0.0-beta.7
* Add doc/.eslintrc.yaml
* Add `plugins: [markdown]` to the main .eslintrc.yaml
* .js files in doc folder added to .eslintignore
* Update Makefile, vcbuild.bat, and tools/jslint.js

Refs: nodejs#12563
Refs: nodejs#12640
Refs: nodejs#14047
vsemozhetbyt added a commit to vsemozhetbyt/node that referenced this pull request Jul 11, 2017
build, doc, tools: add eslint-plugin-markdown
* Install eslint-plugin-markdown@1.0.0-beta.7
* Add doc/.eslintrc.yaml
* Add `plugins: [markdown]` to the main .eslintrc.yaml
* .js files in doc folder added to .eslintignore
* Update Makefile, vcbuild.bat, and tools/jslint.js

Refs: nodejs#12563
Refs: nodejs#12640
Refs: nodejs#14047
vsemozhetbyt added a commit to vsemozhetbyt/node that referenced this pull request Jul 11, 2017
build, doc, tools: add eslint-plugin-markdown
* Install eslint-plugin-markdown@1.0.0-beta.7
* Add doc/.eslintrc.yaml
* Add `plugins: [markdown]` to the main .eslintrc.yaml
* .js files in doc folder added to .eslintignore
* Update Makefile, vcbuild.bat, and tools/jslint.js

Refs: nodejs#12563
Refs: nodejs#12640
Refs: nodejs#14047
vsemozhetbyt added a commit to vsemozhetbyt/node that referenced this pull request Jul 19, 2017
build, doc, tools: add eslint-plugin-markdown
* Install eslint-plugin-markdown@1.0.0-beta.7
* Add doc/.eslintrc.yaml
* Add `plugins: [markdown]` to the main .eslintrc.yaml
* .js files in doc folder added to .eslintignore
* Update Makefile, vcbuild.bat, and tools/jslint.js

Refs: nodejs#12563
Refs: nodejs#12640
Refs: nodejs#14047
MylesBorins added a commit that referenced this pull request Jul 21, 2017
build, doc, tools: add eslint-plugin-markdown
* Install eslint-plugin-markdown@1.0.0-beta.7
* Add doc/.eslintrc.yaml
* Add `plugins: [markdown]` to the main .eslintrc.yaml
* .js files in doc folder added to .eslintignore
* Update Makefile, vcbuild.bat, and tools/jslint.js

Refs: #12563
Refs: #12640
Refs: #14047

PR-URL: #14067
Reviewed-By: James Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins added a commit that referenced this pull request Jul 21, 2017
build, doc, tools: add eslint-plugin-markdown
* Install eslint-plugin-markdown@1.0.0-beta.7
* Add doc/.eslintrc.yaml
* Add `plugins: [markdown]` to the main .eslintrc.yaml
* .js files in doc folder added to .eslintignore
* Update Makefile, vcbuild.bat, and tools/jslint.js

Refs: #12563
Refs: #12640
Refs: #14047

PR-URL: #14067
Reviewed-By: James Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins added a commit that referenced this pull request Jul 31, 2017
build, doc, tools: add eslint-plugin-markdown
* Install eslint-plugin-markdown@1.0.0-beta.7
* Add doc/.eslintrc.yaml
* Add `plugins: [markdown]` to the main .eslintrc.yaml
* .js files in doc folder added to .eslintignore
* Update Makefile, vcbuild.bat, and tools/jslint.js

Refs: #12563
Refs: #12640
Refs: #14047

PR-URL: #14067
Reviewed-By: James Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.